On Wed, 1 Jun 2022 16:45:35 GMT, liach wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> do it as naotoj said
>
> 'the new' fix should be applied to newHashMap etc. too.
@liach
> 'the new' fix should be applied to ne
On Tue, 23 Aug 2022 22:44:13 GMT, Naoto Sato wrote:
> This is to enhance the character break analysis in `java.text.BreakIterator`
> to conform to the extended grapheme cluster boundaries defined in
> https://www.unicode.org/reports/tr29/#Grapheme_Cluster_Boundaries. A
> corresponding CSR has
On Tue, 23 Aug 2022 22:44:13 GMT, Naoto Sato wrote:
> This is to enhance the character break analysis in `java.text.BreakIterator`
> to conform to the extended grapheme cluster boundaries defined in
> https://www.unicode.org/reports/tr29/#Grapheme_Cluster_Boundaries. A
> corresponding CSR has
On Tue, 23 Aug 2022 22:44:13 GMT, Naoto Sato wrote:
> This is to enhance the character break analysis in `java.text.BreakIterator`
> to conform to the extended grapheme cluster boundaries defined in
> https://www.unicode.org/reports/tr29/#Grapheme_Cluster_Boundaries. A
> corresponding CSR has
On Fri, 26 Aug 2022 18:12:04 GMT, Naoto Sato wrote:
>> This is to enhance the character break analysis in `java.text.BreakIterator`
>> to conform to the extended grapheme cluster boundaries defined in
>> https://www.unicode.org/reports/tr29/#Grapheme_Cluster_Boundaries. A
>> corresponding CSR
On Fri, 26 Aug 2022 21:48:14 GMT, Naoto Sato wrote:
>> This is to enhance the character break analysis in `java.text.BreakIterator`
>> to conform to the extended grapheme cluster boundaries defined in
>> https://www.unicode.org/reports/tr29/#Grapheme_Cluster_Boundaries. A
>> corresponding CSR
On Thu, 8 Sep 2022 18:32:56 GMT, Naoto Sato wrote:
>> This is to enhance the character break analysis in `java.text.BreakIterator`
>> to conform to the extended grapheme cluster boundaries defined in
>> https://www.unicode.org/reports/tr29/#Grapheme_Cluster_Boundaries. A
>> corresponding CSR h
On Mon, 19 Sep 2022 22:18:42 GMT, Naoto Sato wrote:
>> Yeah, I saw there's a mismatch between the src and limit in this call that
>> led to the index check Exception:
>> 286 for (int b = ci.getBeginIndex(); b < end;) {
>> 287 boundaries.add(b);
>> 288
On Tue, 20 Sep 2022 01:14:38 GMT, Naoto Sato wrote:
>> Fixing JCK failures caused by the new grapheme implementation. The length of
>> a CharSequence should return the `endIndex`, not `endIndex - beginIndex`.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit
On Tue, 20 Sep 2022 01:09:29 GMT, Naoto Sato wrote:
>> OK yeah this is really confusing. One might ask a similar question in
>> `charAt` about why it doesn't call
>>
>> src.setIndex(index + src.getBeginIndex());
>>
>> The answer is that this is a special-purpose `CharSequence` that represe
On Mon, 31 Oct 2022 20:11:34 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of evalu
On Fri, 13 Jan 2023 22:54:47 GMT, Joe Darcy wrote:
>> With generalized see and link tags that can refer to anchors (JDK-8200337),
>> the see and link tags in core libraries should be updated to use this
>> feature when possible. This PR covers such updates for java.base.
>
> Joe Darcy has updat
On Tue, 6 Jun 2023 18:48:35 GMT, John R Rose wrote:
>> This reasoning seems invalid. There are method calls in there, and you rely
>> on inlining heuristics for this not to break. Please use reachabilityFence
>> instead.
>
> It appears you are assuming that some combination of bytecodes constit
On Tue, 4 Jul 2023 22:03:58 GMT, John R Rose wrote:
>>> Hmm, I think that issue refers to code that have explicit non-Object
>>> parameter types (like `X::equals(Object)boolean` in the issue's sample).
>>> This method already have both arguments as `Object`, so I don't think
>>> there's any ty
On Mon, 11 Dec 2023 23:17:01 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/util/Locale.java line 301:
>>
>>> 299: * is unparsable, it is ignored. The overriding values of other
>>> properties are not
>>> 300: * checked for syntax or validity and are used directly in the default
On Mon, 11 Dec 2023 23:20:25 GMT, Naoto Sato wrote:
>> This is a doc change to clarify what the `Default Locale` is, and how it is
>> established during the system startup using the system properties. Those
>> locale-related system properties have existed since the early days of Java,
>> but h
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote:
> After the "this-escape" lint warning was added to javac (JDK-8015831), the
> base module was not updated to be able to compile with this warning enabled.
> This PR makes the necessary changes to allow the base module to build with
> the warni
On Thu, 14 Nov 2024 22:09:59 GMT, Roger Riggs wrote:
> Remove use of doPrivileged and SecurityManager in java.util.
Marked as reviewed by smarks (Reviewer).
I mainly wanted to look at Arrays, and I looked briefly at the other stuff too.
All looks good.
-
PR Review: https://git.op
18 matches
Mail list logo
