Re: RFR: 8342903: Deprecate for removal java.awt.Window.getWarningString() [v2]

2024-11-20 Thread Phil Race
On Tue, 19 Nov 2024 19:29:28 GMT, Phil Race wrote: >> This fix deprecates for removal java.awt.Window.getWarningString() and also >> javax.swing.JInternalFrame.getWarningString() >> l java.awt.Window.getWarningString() is only relevant with a SecurityManager >> and javax.swing.JInternalFrame.ge

Re: RFR: 8342903: Deprecate for removal java.awt.Window.getWarningString() [v3]

2024-11-20 Thread Phil Race
> This fix deprecates for removal java.awt.Window.getWarningString() and also > javax.swing.JInternalFrame.getWarningString() > l java.awt.Window.getWarningString() is only relevant with a SecurityManager > and javax.swing.JInternalFrame.getWarningString() is just there for symmetry. > > A few o

RFR: 8344664: Remove some un-used java/sun.security imports in the java.desktop module

2024-11-20 Thread Phil Race
delete un-used imports and obsolete comments - Commit messages: - 8344664 Changes: https://git.openjdk.org/jdk/pull/22286/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22286&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344664 Stats: 21 lines in 13 files change

Re: RFR: 8341923: java.util.Locale class specification improvements [v3]

2024-11-20 Thread Naoto Sato
On Wed, 20 Nov 2024 03:03:22 GMT, Justin Lu wrote: >> Please review this PR and corresponding CSR which includes a wide range of >> specification improvements for java.util.Locale. See the CSR for further >> detail. Other changes/suggestions are welcomed to be included as part of >> this chang

Re: RFR: 8341923: java.util.Locale class specification improvements [v3]

2024-11-20 Thread Naoto Sato
On Wed, 20 Nov 2024 02:58:45 GMT, Justin Lu wrote: >> src/java.base/share/classes/java/util/Locale.java line 144: >> >>> 142: * each indicating its own semantics, these values should be ordered >>> 143: * by importance, with most important first, separated by >>> 144: * underscore('_').

RFR: 8319993: Update Unicode Data Files to 16.0.0

2024-11-20 Thread Naoto Sato
Updates the JDK to use the latest Unicode 16.0.0, which also updates the ICU4J along with it (8319992: Update ICU4J to Version 76.1). The corresponding CSR has already been approved. - Commit messages: - icu.md changes - Merge branch 'master' into JDK-8319993-Unicode-16 - Merge b

Re: RFR: 8342903: Deprecate for removal java.awt.Window.getWarningString() [v2]

2024-11-20 Thread Phil Race
On Tue, 19 Nov 2024 19:29:28 GMT, Phil Race wrote: >> This fix deprecates for removal java.awt.Window.getWarningString() and also >> javax.swing.JInternalFrame.getWarningString() >> l java.awt.Window.getWarningString() is only relevant with a SecurityManager >> and javax.swing.JInternalFrame.ge

Re: RFR: 8344589: Update IANA Language Subtag Registry to Version 2024-11-19

2024-11-20 Thread Lance Andersen
On Wed, 20 Nov 2024 02:59:54 GMT, Justin Lu wrote: > Please review this PR which keeps the IANA language subtag registry data up > to date with release _2024-11-19_. > > The changes are trivial and Locale tests pass as expected. Marked as reviewed by lancea (Reviewer). - PR Revie

Re: RFR: 8344589: Update IANA Language Subtag Registry to Version 2024-11-19

2024-11-20 Thread Naoto Sato
On Wed, 20 Nov 2024 02:59:54 GMT, Justin Lu wrote: > Please review this PR which keeps the IANA language subtag registry data up > to date with release _2024-11-19_. > > The changes are trivial and Locale tests pass as expected. Marked as reviewed by naoto (Reviewer). - PR Review

Re: RFR: 8341923: java.util.Locale class specification improvements [v3]

2024-11-20 Thread Justin Lu
On Wed, 20 Nov 2024 18:20:04 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> address Naoto's comments > > src/java.base/share/classes/java/util/Locale.java line 1256: > >> 1254: >> 1255: /** >> 1

Re: RFR: 8341923: java.util.Locale class specification improvements [v4]

2024-11-20 Thread Justin Lu
> Please review this PR and corresponding CSR which includes a wide range of > specification improvements for java.util.Locale. See the CSR for further > detail. Other changes/suggestions are welcomed to be included as part of this > change. > > APIDiff: > https://cr.openjdk.org/~jlu/8341923_a

Re: RFR: 8344664: Remove some un-used java/sun.security imports in the java.desktop module

2024-11-20 Thread Iris Clark
On Wed, 20 Nov 2024 23:18:48 GMT, Phil Race wrote: > delete un-used imports and obsolete comments Builds succeeded. Deleted imports clearly not needed. - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/22286#pullrequestreview-2450188200

Integrated: 8344664: Remove some un-used java/sun.security imports in the java.desktop module

2024-11-20 Thread Phil Race
On Wed, 20 Nov 2024 23:18:48 GMT, Phil Race wrote: > delete un-used imports and obsolete comments This pull request has now been integrated. Changeset: 7105bb98 Author:Phil Race URL: https://git.openjdk.org/jdk/commit/7105bb98cf8797082d2b61f0e08a4e5ba0bae8ac Stats: 21 lines in 1