Re: RFR: 8344330: Remove AccessController.doPrivileged() from jdk.charsets module [v2]

2024-11-15 Thread Lance Andersen
On Fri, 15 Nov 2024 20:17:59 GMT, Naoto Sato wrote: >> Removing a `AccessController.doPrivileged()` call from jdk.charsets module >> after JEP486 integration. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > fixed import Mar

Re: RFR: 8344252: SM cleanup in java.util classes [v3]

2024-11-15 Thread Roger Riggs
> Remove use of doPrivileged and SecurityManager in java.util. Roger Riggs has updated the pull request incrementally with one additional commit since the last revision: Correct @see link syntax in AbstractResourceBundleProvider - Changes: - all: https://git.openjdk.org/jdk/pul

Re: RFR: 8344252: SM cleanup in java.util classes [v3]

2024-11-15 Thread Naoto Sato
On Fri, 15 Nov 2024 17:52:28 GMT, Roger Riggs wrote: >> Remove use of doPrivileged and SecurityManager in java.util. > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Correct @see link syntax in AbstractResourceBundleProvider

Re: RFR: 8344252: SM cleanup in java.util classes [v2]

2024-11-15 Thread Roger Riggs
> Remove use of doPrivileged and SecurityManager in java.util. Roger Riggs has updated the pull request incrementally with one additional commit since the last revision: Applied suggestions from review comments - Changes: - all: https://git.openjdk.org/jdk/pull/22122/files -

Re: RFR: 8344252: SM cleanup in java.util classes [v2]

2024-11-15 Thread Naoto Sato
On Fri, 15 Nov 2024 16:06:41 GMT, Roger Riggs wrote: >> Remove use of doPrivileged and SecurityManager in java.util. > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Applied suggestions from review comments src/java.base/sha

RFR: 8344330: Remove AccessController.doPrivileged() from jdk.charsets module

2024-11-15 Thread Naoto Sato
Removing a `AccessController.doPrivileged()` call from jdk.charsets module after JEP486 integration. - Commit messages: - initial commit Changes: https://git.openjdk.org/jdk/pull/22162/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22162&range=00 Issue: https://bugs.ope

Re: RFR: 8344330: Remove AccessController.doPrivileged() from jdk.charsets module [v2]

2024-11-15 Thread Justin Lu
On Fri, 15 Nov 2024 20:17:59 GMT, Naoto Sato wrote: >> Removing a `AccessController.doPrivileged()` call from jdk.charsets module >> after JEP486 integration. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > fixed import Mar

Re: RFR: 8344061: Remove doPrivileged calls from shared implementation code in the java.desktop module : part 2

2024-11-15 Thread Harshitha Onkar
On Fri, 15 Nov 2024 19:18:15 GMT, Phil Race wrote: > Update 21 desktop module shared implementation files to remove doPrivileged. > All the usual tests still pass. src/java.desktop/share/classes/sun/awt/AppContext.java line 248: > 246: new ThreadLocal(); > 247: > 248: //@Suppre

Re: RFR: 8344330: Remove AccessController.doPrivileged() from jdk.charsets module [v2]

2024-11-15 Thread Brian Burkhalter
On Fri, 15 Nov 2024 20:17:59 GMT, Naoto Sato wrote: >> Removing a `AccessController.doPrivileged()` call from jdk.charsets module >> after JEP486 integration. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > fixed import Upd

Integrated: 8344062: Remove doPrivileged calls from awt and beans classes in the java.desktop module

2024-11-15 Thread Phil Race
On Thu, 14 Nov 2024 18:45:00 GMT, Phil Race wrote: > Remove doPrivileged from java.awt and java.beans packages. > Automated tests pass. SwingSet OK. This pull request has now been integrated. Changeset: 1bb0d3ba Author:Phil Race URL: https://git.openjdk.org/jdk/commit/1bb0d3baaa3e6b

Re: RFR: 8344330: Remove AccessController.doPrivileged() from jdk.charsets module [v2]

2024-11-15 Thread Roger Riggs
On Fri, 15 Nov 2024 20:15:10 GMT, Naoto Sato wrote: >> Removing a `AccessController.doPrivileged()` call from jdk.charsets module >> after JEP486 integration. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > fixed import loo

Integrated: 8344252: SM cleanup in java.util classes

2024-11-15 Thread Roger Riggs
On Thu, 14 Nov 2024 22:09:59 GMT, Roger Riggs wrote: > Remove use of doPrivileged and SecurityManager in java.util. This pull request has now been integrated. Changeset: c5b6ed8c Author:Roger Riggs URL: https://git.openjdk.org/jdk/commit/c5b6ed8ca0d4f9862fd6a890bcd457f73582696d Stat

Re: RFR: 8344330: Remove AccessController.doPrivileged() from jdk.charsets module [v2]

2024-11-15 Thread Naoto Sato
> Removing a `AccessController.doPrivileged()` call from jdk.charsets module > after JEP486 integration. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: fixed import - Changes: - all: https://git.openjdk.org/jdk/pull/22

RFR: 8344061: Remove doPrivileged calls from shared implementation code in the java.desktop module : part 2

2024-11-15 Thread Phil Race
Update 21 desktop module shared implementation files to remove doPrivileged. All the usual tests still pass. - Commit messages: - 8344061 Changes: https://git.openjdk.org/jdk/pull/22161/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22161&range=00 Issue: https://bugs.ope

Re: RFR: 8344061: Remove doPrivileged calls from shared implementation code in the java.desktop module : part 2

2024-11-15 Thread Phil Race
On Fri, 15 Nov 2024 19:18:15 GMT, Phil Race wrote: > Update 21 desktop module shared implementation files to remove doPrivileged. > All the usual tests still pass. src/java.desktop/share/classes/sun/awt/datatransfer/DataTransferer.java line 1013: > 1011: } > 1012: > 1013: private stat

Re: RFR: 8344330: Remove AccessController.doPrivileged() from jdk.charsets module

2024-11-15 Thread Lance Andersen
On Fri, 15 Nov 2024 19:26:15 GMT, Naoto Sato wrote: > Removing a `AccessController.doPrivileged()` call from jdk.charsets module > after JEP486 integration. Marked as reviewed by lancea (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/22162#pullrequestreview-2439458103

Re: RFR: 8344330: Remove AccessController.doPrivileged() from jdk.charsets module

2024-11-15 Thread Brian Burkhalter
On Fri, 15 Nov 2024 19:26:15 GMT, Naoto Sato wrote: > Removing a `AccessController.doPrivileged()` call from jdk.charsets module > after JEP486 integration. Looks fine. - Marked as reviewed by bpb (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/22162#pullrequestreview-243