Found many typos in java.desktop by IDEA's inspection `Proofreading | Typo`
-
Commit messages:
- [PATCH] Fix typos in java.desktop
- [PATCH] Fix typos in java.desktop
- [PATCH] Fix typos in java.desktop
Changes: https://git.openjdk.org/jdk/pull/14847/files
Webrev: https://webrevs
On Thu, 13 Jul 2023 23:23:42 GMT, Justin Lu wrote:
> Please review this PR which refactors more java.util.Locale tests to JUnit
> with some minor cleanup as well.
>
> Although some of the files could benefit from being renamed bugNNN to
> something more descriptive, this makes reviewing ha
On Tue, 31 Jan 2023 15:57:43 GMT, Per Minborg wrote:
> `ZoneOffset` instances are cached by the `ZoneOffset` class itself for values
> in the range [-18h, 18h] for each second that is on an even quarter of an
> hour (i.e. at most 2*18*4+1 = 145 values).
>
> Instead of using a `ConcurrentHashM
Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8312197)
which updates the javadoc for the constructor of MessageFormat regarding a
`null` locale,
`MessageFormat` when created with a `null` locale may throw a
`NullPointerException` either during the object creation, or later
On Mon, 17 Jul 2023 10:58:12 GMT, Andrey Turbanov wrote:
>> Justin Lu has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - Review: Explicitly run via othervm and pass locale args in cmdline
>> - Review: ws removal in Bug8179071.java
>> -
On Fri, 14 Jul 2023 21:59:40 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - Review: Explicitly run via othervm and pass locale args in cmdline
>> - Review: ws removal in Bug8179071.java
>> - Revie
> Please review this PR which refactors more java.util.Locale tests to JUnit
> with some minor cleanup as well.
>
> Although some of the files could benefit from being renamed bugNNN to
> something more descriptive, this makes reviewing harder, and will be handled
> separately.
Justin Lu h
On Mon, 17 Jul 2023 21:31:33 GMT, Justin Lu wrote:
>> Please review this PR which refactors more java.util.Locale tests to JUnit
>> with some minor cleanup as well.
>>
>> Although some of the files could benefit from being renamed bugNNN to
>> something more descriptive, this makes reviewi
On Mon, 17 Jul 2023 21:04:48 GMT, Justin Lu wrote:
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8312197)
> which updates the javadoc for the constructor of MessageFormat regarding a
> `null` locale,
>
> `MessageFormat` when created with a `null` locale may throw a
> `
> Please review this PR to use modern APIs and language features to simplify
> `equals` and `hashCode` in the java.text area.
>
> * Some changes to `equals` and `hashCode` are refactoring rather than
> modernization. Such changes can be as trivial as rearranging, adding, or
> commenting checks.
On Wed, 12 Jul 2023 22:26:14 GMT, John R Rose wrote:
> Yes, it would be, because `rp` has a statically observable type,
> `BigInteger`. And that observation will flow across the call to the helper
> method.
After all, my mental model is incorrect; sigh.
I read your write-up as though once we
11 matches
Mail list logo
