> Please review this PR to use modern APIs and language features to simplify
> `equals` and `hashCode` in the java.text area.
>
> * Some changes to `equals` and `hashCode` are refactoring rather than
> modernization. Such changes can be as trivial as rearranging, adding, or
> commenting checks.
On Wed, 5 Jul 2023 17:44:52 GMT, Roger Riggs wrote:
>> You are right, I have no stats. Performance-wise, it's already better than
>> what was there before. Before, there was no short-circuit check. But I can
>> go either way; I don't have a strong opinion.
>>
>> Reusing superclass' equals is n
On Wed, 5 Jul 2023 15:33:13 GMT, Roger Riggs wrote:
> I'd suggest replacing the calls to `valuesMatch` with `Objects.equals` and
> remove the `valuesMatch` method as unnecessary.
I'll do something about them soon, Roger. But first I need to understand
JDK-8015417 better, as it also affects oth
On Thu, 6 Jul 2023 14:46:59 GMT, Pavel Rappo wrote:
>> I'd suggest replacing the calls to `valuesMatch` with `Objects.equals` and
>> remove the `valuesMatch` method as unnecessary.
>
>> I'd suggest replacing the calls to `valuesMatch` with `Objects.equals` and
>> remove the `valuesMatch` method
On Thu, 6 Jul 2023 00:30:14 GMT, Naoto Sato wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [d072c40f](https://github.com/openjdk/jdk/commit/d072c40ff175c653802796673baef47e24038891)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being
> Please review this PR which refactors additional tests in Locale to use JUnit.
>
> If a test was named bugNNN.java, it was renamed to something more
> descriptive.
>
> Below is a list of all the changes
>
> - Refactor and Rename Bug4175998Test.java as ISO639.java
> - Refactor and Rename B
On Mon, 3 Jul 2023 17:55:51 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Review: Remove Bug8025703.java and add to LSRT.java
>> - Review: Clarify comments in ISO639.java
>
> test/jdk/java/util/Lo
On Thu, 6 Jul 2023 19:32:09 GMT, Justin Lu wrote:
>> Please review this PR which refactors additional tests in Locale to use
>> JUnit.
>>
>> If a test was named bugNNN.java, it was renamed to something more
>> descriptive.
>>
>> Below is a list of all the changes
>>
>> - Refactor and Ren
Removing the IDE specific `@SuppressWarnings` attached to
`java.util.Calendar#equals()`. `equals()` implementation now checks the type of
the other instance for this.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/14790/files
Webrev: https://webrevs
On Thu, 6 Jul 2023 19:32:09 GMT, Justin Lu wrote:
>> Please review this PR which refactors additional tests in Locale to use
>> JUnit.
>>
>> If a test was named bugNNN.java, it was renamed to something more
>> descriptive.
>>
>> Below is a list of all the changes
>>
>> - Refactor and Ren
On Thu, 6 Jul 2023 21:03:29 GMT, Naoto Sato wrote:
> Removing the IDE specific `@SuppressWarnings` attached to
> `java.util.Calendar#equals()`. `equals()` implementation now checks the type
> of the other instance for this.
Marked as reviewed by lancea (Reviewer).
-
PR Review: ht
On Thu, 6 Jul 2023 21:03:29 GMT, Naoto Sato wrote:
> Removing the IDE specific `@SuppressWarnings` attached to
> `java.util.Calendar#equals()`. `equals()` implementation now checks the type
> of the other instance for this.
Marked as reviewed by bpb (Reviewer).
-
PR Review: https
On Thu, 6 Jul 2023 21:03:29 GMT, Naoto Sato wrote:
> Removing the IDE specific `@SuppressWarnings` attached to
> `java.util.Calendar#equals()`. `equals()` implementation now checks the type
> of the other instance for this.
Marked as reviewed by jlu (Committer).
-
PR Review: http
On Thu, 23 Feb 2023 09:04:23 GMT, Justin Lu wrote:
> This PR converts Unicode sequences to UTF-8 native in .properties file.
> (Excluding the Unicode space and tab sequence). The conversion was done using
> native2ascii.
>
> In addition, the build logic is adjusted to support reading in the
>
On Tue, 4 Jul 2023 22:03:58 GMT, John R Rose wrote:
>>> Hmm, I think that issue refers to code that have explicit non-Object
>>> parameter types (like `X::equals(Object)boolean` in the issue's sample).
>>> This method already have both arguments as `Object`, so I don't think
>>> there's any ty
On Thu, 6 Jul 2023 23:38:01 GMT, Stuart Marks wrote:
> For me the issue here is that there is a bunch of lore about avoiding
> `Objects::equals` and it's embodied in comments like this:
>
> > NB: Do not replace with Object.equals until JDK-8015417 is resolved.
>
> These comments are almost exa
On Tue, 27 Jun 2023 19:04:35 GMT, Justin Lu wrote:
> Please review this PR which refactors Currency tests to use JUnit.
>
> The most significant change occurs in `ValidateISO4217.java`. Other changes
> to this file excluding the JUnit refactoring include
>
> - Tests are no longer dependent on
17 matches
Mail list logo
