On Tue, 17 Jun 2025 18:23:30 GMT, Phil Race wrote:
>> This is the implementation of JEP 504 - Remove the Applet API.
>> API changes are
>> - Remove the entire java.applet package
>> - Remove the javax/swing/JApplet class
>> - Remove applet related APIs in java.beans
>> - Update javadoc referring
On Tue, 17 Jun 2025 21:24:51 GMT, Alexey Ivanov wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8359053
>
> test/jdk/javax/sound/sampled/Clip/AudioContentHandlers.java line 87:
>
>> 85: generateOO
On Fri, 13 Jun 2025 21:51:05 GMT, Phil Race wrote:
> I am inclined to ask the networking API owners what the purpose and future
> should be.
Yeah, that will be useful to know the future of this api, we have similar
handlers for images.
-
PR Review Comment: https://git.openjdk.org
On Fri, 13 Jun 2025 19:59:36 GMT, Phil Race wrote:
>> test/jdk/javax/sound/sampled/Clip/DataPusherThreadCheck.java line 73:
>>
>>> 71:
>>> 72: private static void checkThread(File file) throws Exception {
>>> 73: SoundClip clip = SoundClip.createSoundClip(file);
>>
>> I think we sh
On Thu, 12 Jun 2025 23:06:41 GMT, Sergey Bylokhov wrote:
>> I am not sure that's the case. I think it best to leave the comment as it is
>> - minus mention of applet.
>
> After the applet removal, this could be dead code. It might be better not to
> mention JInternal
On Thu, 12 Jun 2025 21:54:03 GMT, Phil Race wrote:
>> src/java.desktop/share/classes/java/awt/Window.java line 3864:
>>
>>> 3862: content.setOpaque(isOpaque);
>>> 3863:
>>> 3864: // Iterate down one level to see whether we have (eg)
>>> a JInternalFrame
>>
>> I
On Thu, 12 Jun 2025 22:20:01 GMT, Phil Race wrote:
>> This is the implementation of JEP 504 - Remove the Applet API.
>> API changes are
>> - Remove the entire java.applet package
>> - Remove the javax/swing/JApplet class
>> - Remove applet related APIs in java.beans
>> - Update javadoc referring
On Thu, 12 Jun 2025 21:45:50 GMT, Phil Race wrote:
>> src/java.desktop/share/classes/javax/imageio/spi/IIORegistry.java line 113:
>>
>>> 111: * registry functions.
>>> 112: *
>>> 113: * Each {@code ThreadGroup} will receive its own instance.
>>
>> Note that this new specificatio
On Thu, 12 Jun 2025 22:34:51 GMT, Phil Race wrote:
>> test/jdk/javax/sound/sampled/Clip/AudioContentHandlers.java line 51:
>>
>>> 49: * @run main/othervm -Xmx128m AudioContentHandlers
>>> 50: */
>>> 51: public final class AudioContentHandlers {
>>
>> I see the src/java.desktop/share/classes/s
On Wed, 11 Jun 2025 19:18:15 GMT, Phil Race wrote:
>> This is the implementation of JEP 504 - Remove the Applet API.
>> API changes are
>> - Remove the entire java.applet package
>> - Remove the javax/swing/JApplet class
>> - Remove applet related APIs in java.beans
>> - Update javadoc referring
On Wed, 11 Jun 2025 19:18:15 GMT, Phil Race wrote:
>> This is the implementation of JEP 504 - Remove the Applet API.
>> API changes are
>> - Remove the entire java.applet package
>> - Remove the javax/swing/JApplet class
>> - Remove applet related APIs in java.beans
>> - Update javadoc referring
On Wed, 11 Jun 2025 19:18:15 GMT, Phil Race wrote:
>> This is the implementation of JEP 504 - Remove the Applet API.
>> API changes are
>> - Remove the entire java.applet package
>> - Remove the javax/swing/JApplet class
>> - Remove applet related APIs in java.beans
>> - Update javadoc referring
On Wed, 11 Jun 2025 19:18:15 GMT, Phil Race wrote:
>> This is the implementation of JEP 504 - Remove the Applet API.
>> API changes are
>> - Remove the entire java.applet package
>> - Remove the javax/swing/JApplet class
>> - Remove applet related APIs in java.beans
>> - Update javadoc referring
On Wed, 11 Jun 2025 19:18:15 GMT, Phil Race wrote:
>> This is the implementation of JEP 504 - Remove the Applet API.
>> API changes are
>> - Remove the entire java.applet package
>> - Remove the javax/swing/JApplet class
>> - Remove applet related APIs in java.beans
>> - Update javadoc referring
On Wed, 11 Jun 2025 19:18:15 GMT, Phil Race wrote:
>> This is the implementation of JEP 504 - Remove the Applet API.
>> API changes are
>> - Remove the entire java.applet package
>> - Remove the javax/swing/JApplet class
>> - Remove applet related APIs in java.beans
>> - Update javadoc referring
On Thu, 22 May 2025 21:21:30 GMT, Sergey Bylokhov wrote:
> The issue was found here:
> https://github.com/openjdk/jdk/pull/24692#discussion_r2089545502
>
> AWTEventListener and AWTEventListenerProxy are public classes and there's no
> assertion that EventListenerProx
the test is updated just to touch that codepath.
Sergey Bylokhov has updated the pull request incrementally with one additional
commit since the last revision:
Update
test/jdk/java/awt/Toolkit/AWTEventListenerProxyTest/AWTEventListenerProxyTest.java
Co-authored-by: Alexey Ivanov
The issue was found here:
https://github.com/openjdk/jdk/pull/24692#discussion_r2089545502
AWTEventListener and AWTEventListenerProxy are public classes and there's no
assertion that EventListenerProxy.getListener() will always return a non-null
value. So removeAWTEventListener method should fe
On Thu, 22 May 2025 21:21:30 GMT, Sergey Bylokhov wrote:
> The issue was found here:
> https://github.com/openjdk/jdk/pull/24692#discussion_r2089545502
>
> AWTEventListener and AWTEventListenerProxy are public classes and there's no
> assertion that EventListenerProx
On Mon, 19 May 2025 12:23:27 GMT, Alexey Ivanov wrote:
>> Looks like yes. I think it's worth to create a separate issue to fix it.
>
> It doesn't matter, it looks… `localL` is `null` if and only if listener is
> `null`.
>
> However, I'd put the null-check above the call to `deProxyAWTEventListe
On Wed, 16 Apr 2025 15:07:36 GMT, Andrey Turbanov wrote:
> Instead of separate `.get`+`.remove` calls we can call `.remove` and then
> compare result with `null`
Marked as reviewed by serb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/24692#pullrequestreview-2852324895
On Wed, 16 Apr 2025 15:07:36 GMT, Andrey Turbanov wrote:
> Instead of separate `.get`+`.remove` calls we can call `.remove` and then
> compare result with `null`
src/java.desktop/share/classes/java/awt/Toolkit.java line 1745:
> 1743: synchronized (this) {
> 1744: SelectiveA
On Wed, 14 May 2025 17:34:45 GMT, Naoto Sato wrote:
>> For the l10n files, they are synced by the translation team and we don't
>> edit them. IMO, I think it's fine leaving those ones as is. Especially
>> because language rules can cause different spacing and punctuation
>> characters, so gene
On Wed, 16 Apr 2025 14:48:04 GMT, Andrey Turbanov wrote:
> To obtain previous value of `HashMap` we can use result of `.put` call. In
> this case we can avoid redundant `.get` call.
Marked as reviewed by serb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/24691#pullrequ
On Wed, 16 Apr 2025 14:48:04 GMT, Andrey Turbanov wrote:
> To obtain previous value of `HashMap` we can use result of `.put` call. In
> this case we can avoid redundant `.get` call.
looks fine
-
PR Comment: https://git.openjdk.org/jdk/pull/24691#issuecomment-2874815079
On Mon, 14 Apr 2025 12:53:35 GMT, Magnus Ihse Bursie wrote:
>> Most of the JDK code base has been transitioned to UTF-8, but not all. This
>> has recently become an acute problem, since our mixing of iso-8859-1 and
>> utf-8 in properties files confused the version of `sed` that is shipped with
On Thu, 10 Apr 2025 10:10:49 GMT, Magnus Ihse Bursie wrote:
> I have checked the entire code base for incorrect encodings, but luckily
> enough these were the only remaining problems I found.
>
> BOM (byte-order mark) is a method used for distinguishing big and little
> endian UTF-16 encoding
On Thu, 14 Nov 2024 18:45:00 GMT, Phil Race wrote:
> Remove doPrivileged from java.awt and java.beans packages.
> Automated tests pass. SwingSet OK.
Marked as reviewed by serb (Reviewer).
Interestingly, none of the tests had to be updated.
-
PR Review: https://git.openjdk.org/jdk/
On Mon, 3 Apr 2023 23:40:05 GMT, Yoshiki Sato wrote:
>> Pleases review this PR.
>> The PR includes the following changes.
>> - tzdata 2023c
>> - Hack code to deal with Cairo's DST end, which is same as done in
>> 2014g([JDK-8049343](https://bugs.openjdk.org/browse/JDK-8049343)). To work
>> ar
On Fri, 31 Mar 2023 00:02:02 GMT, Yoshiki Sato wrote:
> Pleases review this PR.
> The PR includes the following changes.
> - tzdata 2023c
> - Hack code to deal with Cairo's DST end, which is same as done in
> 2014g([JDK-8049343](https://bugs.openjdk.org/browse/JDK-8049343)). To work
> around
On Sun, 12 Mar 2023 17:35:40 GMT, Jeremy wrote:
> I'm confident about the new test case for this ticket, but the resolution is
> more invasive than I'd like. (It works, though.)
>
> In short:
> This introduces a new RenderingHint (in SunHints) to bypass the call in
> Window to `gg2d.fillRect(0
On Sun, 12 Mar 2023 17:35:40 GMT, Jeremy wrote:
> I'm confident about the new test case for this ticket, but the resolution is
> more invasive than I'd like. (It works, though.)
>
> In short:
> This introduces a new RenderingHint (in SunHints) to bypass the call in
> Window to `gg2d.fillRect(0
On Tue, 14 Mar 2023 00:07:33 GMT, Jeremy wrote:
> If you still want me to try to migrate this logic: can you give me an example
> of which classes you'd recommend trying to move it to?
That logic exists there to clear the window if it does not opaque and have some
translucent pixels, and it wa
On Sun, 12 Mar 2023 17:35:40 GMT, Jeremy wrote:
> I'm confident about the new test case for this ticket, but the resolution is
> more invasive than I'd like. (It works, though.)
>
> In short:
> This introduces a new RenderingHint (in SunHints) to bypass the call in
> Window to `gg2d.fillRect(0
On Mon, 9 Jan 2023 03:57:17 GMT, Prasanta Sadhukhan
wrote:
>> Some methods and constants has a hyperreference to self in javadoc which is
>> rectified to reference proper methods
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revis
On Fri, 6 Jan 2023 05:57:08 GMT, Prasanta Sadhukhan
wrote:
>> Some methods and constants has a hyperreference to self in javadoc which is
>> rectified to reference proper methods
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revis
On Fri, 6 Jan 2023 05:25:29 GMT, Prasanta Sadhukhan
wrote:
>> Some methods and constants has a hyperreference to self in javadoc which is
>> rectified to reference proper methods
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revis
On Tue, 3 Jan 2023 06:00:37 GMT, Prasanta Sadhukhan
wrote:
> Some methods and constants has a hyperreference to self in javadoc which is
> rectified to reference proper methods
src/java.desktop/share/classes/java/awt/Component.java line 2268:
> 2266: * of this component
> 2267:
On Mon, 2 Jan 2023 07:20:43 GMT, Sergey Bylokhov wrote:
> Small cleanup, unnecessary semicolons are deleted here and there.
This pull request has now been integrated.
Changeset: e7361cb7
Author: Sergey Bylokhov
URL:
https://git.openjdk.org/jdk/com
On Tue, 3 Jan 2023 11:30:14 GMT, Ajit Ghaisas wrote:
> I see that this PR touches only java files. A few native files have these
> type of typos as well. I think, it is worth cleaning them as well.
"A few" is too optimistic, we have thousand empty statements caused by the
semicolons. Most of t
> Small cleanup, unnecessary semicolons are deleted here and there.
Sergey Bylokhov has updated the pull request incrementally with one additional
commit since the last revision:
native on win
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11807/files
- new: ht
> Small cleanup, unnecessary semicolons are deleted here and there.
Sergey Bylokhov has updated the pull request incrementally with one additional
commit since the last revision:
native on mac
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11807/files
- new: ht
Small cleanup, unnecessary semicolons are deleted here and there.
-
Commit messages:
- 8299430: Cleanup: delete unnecessary semicolons in java.desktop module
Changes: https://git.openjdk.org/jdk/pull/11807/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11807&range=00
Issu
On Fri, 2 Dec 2022 17:06:23 GMT, Magnus Ihse Bursie wrote:
> [JDK-8295729](https://bugs.openjdk.org/browse/JDK-8295729) was created in an
> attempt to remove all trailing whitespace from properties files, and enable a
> jcheck verification that they did not come back, similar to other source
>
On Wed, 2 Nov 2022 04:10:43 GMT, Yoshiki Sato wrote:
> Please review this PR. The PR includes changes in the resource bundle
> sources to follow the time zone change observed in America/Chihuahua and
> America/Ojinaga.
Looks fine
-
Marked as reviewed by serb (Reviewer).
PR: htt
45 matches
Mail list logo
