On Fri, 1 Aug 2025 19:05:27 GMT, Naoto Sato wrote:
>> Enabling lenient minus sign matching when parsing numbers. In some locales,
>> e.g. Finnish, the default minus sign is the Unicode "Minus Sign" (U+2212),
>> which is not the "Hyphen Minus" (U+002D) that users type in from keyboard.
>> Thus
On Fri, 1 Aug 2025 19:05:27 GMT, Naoto Sato wrote:
>> Enabling lenient minus sign matching when parsing numbers. In some locales,
>> e.g. Finnish, the default minus sign is the Unicode "Minus Sign" (U+2212),
>> which is not the "Hyphen Minus" (U+002D) that users type in from keyboard.
>> Thus
On Thu, 24 Jul 2025 14:50:07 GMT, Tatsunori Uchino wrote:
> Adds `codePointCount()` overloads to `String`, `Character`,
> `(Abstract)StringBuilder`, and `StringBuffer` to make it possible to
> conveniently retrieve the length of a string as code points without extra
> boundary checks.
>
>
>
On Thu, 17 Jul 2025 12:28:06 GMT, Raffaello Giulietti
wrote:
>> Align the behavior of `DecimalFormat` on `double`s with that of `Formatter`.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Added comment to COMPAT st
On Mon, 16 Jun 2025 16:36:43 GMT, Gautham Krishnan
wrote:
> Some methods in the java.time.chrono interfaces—ChronoLocalDate,
> ChronoLocalDateTime, and ChronoZonedDateTime—override methods from the
> java.time.temporal.Temporal interface that are documented to throw
> UnsupportedTemporalTypeE
On Wed, 30 Apr 2025 20:38:59 GMT, Gautham Krishnan wrote:
>> In the following classes, month and day values are stored in fields of type
>> 'int' or 'short'. The range of allowed values is small enough that the type
>> can be 'byte' instead.
>>
>> java.time.YearMonth
>> java.time.MonthDay
>> j
On Tue, 27 May 2025 19:44:55 GMT, Shaojin Wen wrote:
> To test this concurrency problem, we need to build a concurrent competition
> test, which is not a simple task, so I did not add it.
The label `noreg-hard` would be appropriate to indicate a test was not created
due to difficulty.
That lab
On Wed, 30 Apr 2025 18:01:08 GMT, Shaojin Wen wrote:
> Similar to #24959, java.util.Locale.hashCode can also make the same
> improvement.
>
> Replace manual bitwise operations in hashCode implementations of
> java.util.Locale with Double::hashCode.
lgltm
-
Marked as reviewed by
On Wed, 30 Apr 2025 20:38:59 GMT, Gautham Krishnan wrote:
>> In the following classes, month and day values are stored in fields of type
>> 'int' or 'short'. The range of allowed values is small enough that the type
>> can be 'byte' instead.
>>
>> java.time.YearMonth
>> java.time.MonthDay
>> j
On Wed, 30 Apr 2025 20:38:59 GMT, Gautham Krishnan wrote:
>> In the following classes, month and day values are stored in fields of type
>> 'int' or 'short'. The range of allowed values is small enough that the type
>> can be 'byte' instead.
>>
>> java.time.YearMonth
>> java.time.MonthDay
>> j
On Wed, 30 Apr 2025 06:46:07 GMT, Volkan Yazici wrote:
> Replace manual bitwise operations in `hashCode` implementations of
> `java.time` with `Long::hashCode`.
lgtm
-
Marked as reviewed by rriggs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24959#pullrequestreview-280
On Thu, 10 Apr 2025 22:05:04 GMT, Roger Riggs wrote:
> Remove forRemoval = true from @Deprecated annotation of Boolean, Byte,
> Character, Double, Float, Integer, Long, Short.
> And add `SuppressWarnings("deprecation") `where needed; and remove
> `SuppressWarnings(
Remove forRemoval = true from @Deprecated annotation of Boolean, Byte,
Character, Double, Float, Integer, Long, Short.
And add `SuppressWarnings("deprecation") `where needed; and remove
`SuppressWarnings("removal")`
-
Commit messages:
- 8354335: No longer deprecate wrapper class co
On Mon, 24 Mar 2025 23:13:48 GMT, Justin Lu wrote:
>> Please review this specification update for `SimpleDateFormat` which
>> explicitly specifies the behavior for 'reserved' pattern letters. This is a
>> specification update and has the potential low risk of making an
>> implementation non-co
On Thu, 6 Mar 2025 23:36:29 GMT, Naoto Sato wrote:
> Clarifying the explanation for `TemporalUnit.between()`. There is already an
> example for the `HOURS` case where the minutes are not enough to make a full
> hour. Explaining how smaller units contribute to determining the whole
> number, al
On Thu, 30 Jan 2025 14:20:36 GMT, Shaojin Wen wrote:
>> By removing the redundant code logic in
>> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
>> reduced and the performance can be improved.
>
> Shaojin Wen has updated the pull request incrementally with one addi
On Thu, 23 Jan 2025 02:50:46 GMT, Justin Lu wrote:
>> Please review this PR and CSR which adds a method to _java.util.Currency_
>> which returns a stream of the available Currencies.
>>
>> The motivation can be found in the CSR.
>
> Justin Lu has updated the pull request with a new target base
On Fri, 24 Jan 2025 18:00:06 GMT, Justin Lu wrote:
>> Please review this PR and CSR which add a pair of methods to
>> _java.util.TimeZone_ that return a stream of the available IDs. See the CSR
>> for the motivation.
>>
>> A number of existing tests are modified to use the new methods. See
>>
On Mon, 27 Jan 2025 18:30:39 GMT, Justin Lu wrote:
>> Please review this PR which improves the time measurement for cut-over time
>> comparisons when building the available set of currencies in
>> _java.util.Currency._ Currently, a new time was measured for each special
>> case currency. This
On Tue, 21 Jan 2025 18:44:39 GMT, Justin Lu wrote:
>> src/java.base/share/classes/java/util/Currency.java line 469:
>>
>>> 467:
>>> 468: // Initialize the set of available currencies if needed
>>> 469: private static synchronized void initAvailableCurrencies() {
>>
>> Should we make `a
On Fri, 17 Jan 2025 23:10:54 GMT, Justin Lu wrote:
>> Please review this PR and CSR which adds a method to _java.util.Currency_
>> which returns a stream of the available Currencies.
>>
>> The motivation can be found in the CSR.
>
> Justin Lu has updated the pull request incrementally with one
On Fri, 17 Jan 2025 22:39:14 GMT, Justin Lu wrote:
>> Please review this PR and CSR which adds a method to _java.util.Currency_
>> which returns a stream of the available Currencies.
>>
>> The motivation can be found in the CSR.
>
> Justin Lu has updated the pull request incrementally with one
On Tue, 7 Jan 2025 18:27:31 GMT, Naoto Sato wrote:
> Long overdue cleanup, especially the old `javazic` tool, which has been
> maintenance burden for some time.
Marked as reviewed by rriggs (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/22955#pullrequestreview-253530375
> - Fixed compile error
> - Update src/java.base/share/classes/java/time/ZoneOffset.java
>
>Co-authored-by: Roger Riggs
> - initial commit
Looks good to me.
-
Marked as reviewed by rriggs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22854#pullrequestreview-2528032253
On Fri, 20 Dec 2024 18:12:17 GMT, Naoto Sato wrote:
>> Clarifying the documentation of `DateTimeFormatterBuilder.appendZoneId()`
>> and similar methods to align the description with the behavior, in which
>> `ZoneOffset` is only parsed from the formatter for offset texts without any
>> prefixe
On Fri, 20 Dec 2024 19:55:06 GMT, Naoto Sato wrote:
> The change made in [JDK-8288723](https://bugs.openjdk.org/browse/JDK-8288723)
> seems innocuous, but it caused this performance regression. Partially
> reverting the change (ones that involve `computeIfAbsent()`) to the original.
> Provided
On Thu, 19 Dec 2024 22:12:52 GMT, Naoto Sato wrote:
> Clarifying the documentation of `DateTimeFormatterBuilder.appendZoneId()` and
> similar methods to align the description with the behavior, in which
> `ZoneOffset` is only parsed from the formatter for offset texts without any
> prefixes. C
On Tue, 10 Dec 2024 15:31:08 GMT, Roger Riggs wrote:
> Backport this trivial fix to parsing of the system property
> "resource.bundle.debug" to jdk24.
This pull request has now been integrated.
Changeset: 3b53ed7f
Author:Roger Riggs
URL:
https://git.openjd
On Tue, 10 Dec 2024 15:31:08 GMT, Roger Riggs wrote:
> Backport this trivial fix to parsing of the system property
> "resource.bundle.debug" to jdk24.
@LanceAndersen Please review
-
PR Comment: https://git.openjdk.org/jdk/pull/22664#issuecomment-2539329603
Backport this trivial fix to parsing of the system property
"resource.bundle.debug" to jdk24.
-
Commit messages:
- Backport 4f855d1342d55aeee93b7d0c5796fbfd4994c856
Changes: https://git.openjdk.org/jdk/pull/22664/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22664&range=
On Mon, 9 Dec 2024 17:22:14 GMT, Roger Riggs wrote:
> Replace broken getProperty with Boolean.getBoolean.
>
> Manual testing confirms trace messages are enabled with
> `-Dresource.bundle.debug=true`
This pull request has now been integrated.
Changeset: 4f855d13
Author: Roge
On Mon, 9 Dec 2024 15:45:42 GMT, Magnus Ihse Bursie wrote:
>> That git query isn't correct for all the files in the repo. In particular,
>> the copyrights on third party files are NOT updated uniformly when new
>> versions are applied. In particular, XML files are NOT updated.
>
>> That git que
Replace broken getProperty with Boolean.getBoolean.
Manual testing confirms trace messages are enabled with
`-Dresource.bundle.debug=true`
-
Commit messages:
- 8345818: Fix SM cleanup of parsing of System property resource.bundle.debug
Changes: https://git.openjdk.org/jdk/pull/226
On Mon, 9 Dec 2024 08:58:19 GMT, Eirik Bjørsnøs wrote:
>>> Seems like we could simply use
>>> `Boolean.getBoolean("resource.bundle.debug")` instead?
>>
>> Naoto may know the history on this property. It may have been introduced for
>> debugging when working on the RB implementation or maybe it
On Mon, 9 Dec 2024 13:03:06 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Mon, 2 Dec 2024 20:12:39 GMT, Roger Riggs wrote:
> Remove sun/security/action/GetPropertyAction.java and all uses.
>
> Dependent on PR#22418
This pull request has now been integrated.
Changeset: fcf185c8
Author: Roger Riggs
URL:
https://git.openjdk.org/j
On Tue, 3 Dec 2024 14:53:41 GMT, Eirik Bjørsnøs wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove an obsolete comment related to long ago removed useNewThrowable
>
> src/jav
On Tue, 3 Dec 2024 09:40:39 GMT, Eirik Bjørsnøs wrote:
>> Roger Riggs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 15 commits:
>>
>> - Merge branch 'master' into 8345325-sm-remove-getpropert
> Remove sun/security/action/GetPropertyAction.java and all uses.
>
> Dependent on PR#22418
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Remove an obsolete comment related to long ago removed useNew
On Mon, 2 Dec 2024 22:51:55 GMT, Roger Riggs wrote:
>> Remove sun/security/action/GetPropertyAction.java and all uses.
>>
>> Dependent on PR#22418
>
> Roger Riggs has updated the pull request with a new target base due to a
> merge or a rebase. The pull requ
On Mon, 2 Dec 2024 22:51:55 GMT, Roger Riggs wrote:
>> Remove sun/security/action/GetPropertyAction.java and all uses.
>>
>> Dependent on PR#22418
>
> Roger Riggs has updated the pull request with a new target base due to a
> merge or a rebase. The pull requ
> Remove sun/security/action/GetPropertyAction.java and all uses.
>
> Dependent on PR#22418
Roger Riggs has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 15 commits:
- Merge branch 'master' into 8345325-sm-remov
On Mon, 2 Dec 2024 20:40:23 GMT, Eirik Bjørsnøs wrote:
>> Yes, with Sean's changes in #22418, GetPropertyAction et.al. is deleted.
>
> @RogerRiggs Alan may have referred to the import of `java.util.Properties`.
Right, thanks
-
PR Review Comment: https://git.openjdk.org/jdk/pull/224
> Remove sun/security/action/GetPropertyAction.java and all uses.
>
> Dependent on PR#22418
Roger Riggs has updated the pull request incrementally with two additional
commits since the last revision:
- Remove unused import of Properties
- Update copyrights
Remove jdk/sun/securi
On Mon, 2 Dec 2024 20:19:23 GMT, Alan Bateman wrote:
>> Remove sun/security/action/GetPropertyAction.java and all uses.
>>
>> Dependent on PR#22418
>
> src/java.base/share/classes/java/lang/invoke/MethodHandleNatives.java line
> 710:
>
>> 708:
>> 709: static {
>> 710: Properties p
Remove sun/security/action/GetPropertyAction.java and all uses.
Dependent on PR#22418
-
Depends on: https://git.openjdk.org/jdk/pull/22418
Commit messages:
- 8345325: SM cleanup of GetPropertyAction in java.base
Changes: https://git.openjdk.org/jdk/pull/22497/files
Webrev: https
On Mon, 25 Nov 2024 19:14:49 GMT, Roger Riggs wrote:
> SM removal for internal implementation classes:
> java.lang.CharacterName
> java.lang.ref.Finalizer
> jdk.internal.icu.impl.ICUBinary
> jdk.internal.misc.ExtendedMapMode
This pull request has now been integra
On Mon, 25 Nov 2024 23:39:39 GMT, Roger Riggs wrote:
>> SM removal for internal implementation classes:
>> java.lang.CharacterName
>> java.lang.ref.Finalizer
>> jdk.internal.icu.impl.ICUBinary
>> jdk.internal.misc.ExtendedMapMode
>
> Roge
> SM removal for internal implementation classes:
> java.lang.CharacterName
> java.lang.ref.Finalizer
> jdk.internal.icu.impl.ICUBinary
> jdk.internal.misc.ExtendedMapMode
Roger Riggs has updated the pull request incrementally with one additional
commit since th
On Fri, 22 Nov 2024 23:05:11 GMT, Roger Riggs wrote:
> Cleanup of doPrivileged in:
> sun.util.calendar
> sun.util.local/provider
> sun.util.cldr
> sun.util.resources
This pull request has now been integrated.
Changeset: df2d4c15
Author:Roger Riggs
UR
SM removal for internal implementation classes:
java.lang.CharacterName
java.lang.ref.Finalizer
jdk.internal.icu.impl.ICUBinary
jdk.internal.misc.ExtendedMapMode
-
Commit messages:
- Refactored to remove additional doPrivileged calls
- 8344565: SM cleanup in jdk/int
> Cleanup of doPrivileged in:
> sun.util.calendar
> sun.util.local/provider
> sun.util.cldr
> sun.util.resources
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Cleanups recommended by reviewer
---
Cleanup of doPrivileged in:
sun.util.calendar
sun.util.local/provider
sun.util.cldr
sun.util.resources
-
Commit messages:
- 8344898: SM cleanup of java.base sun/util calendar, locale, clde, and
resources
Changes: https://git.openjdk.org/jdk/pull/22336/files
Webrev
On Fri, 15 Nov 2024 20:17:59 GMT, Naoto Sato wrote:
>> Removing a `AccessController.doPrivileged()` call from jdk.charsets module
>> after JEP486 integration.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fixed import
Mar
On Thu, 14 Nov 2024 22:09:59 GMT, Roger Riggs wrote:
> Remove use of doPrivileged and SecurityManager in java.util.
This pull request has now been integrated.
Changeset: c5b6ed8c
Author: Roger Riggs
URL:
https://git.openjdk.org/jdk/commit/c5b6ed8ca0d4f9862fd6a890bcd457f735826
On Fri, 15 Nov 2024 20:15:10 GMT, Naoto Sato wrote:
>> Removing a `AccessController.doPrivileged()` call from jdk.charsets module
>> after JEP486 integration.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fixed import
loo
> Remove use of doPrivileged and SecurityManager in java.util.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Correct @see link syntax in AbstractResourceBundleProvider
-
Changes:
- all: https://git.openjdk.org/
> Remove use of doPrivileged and SecurityManager in java.util.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Applied suggestions from review comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/22122/fi
Remove use of doPrivileged and SecurityManager in java.util.
-
Commit messages:
- 8344252: SM cleanup in java.util classes
Changes: https://git.openjdk.org/jdk/pull/22122/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22122&range=00
Issue: https://bugs.openjdk.org/browse
On Tue, 12 Nov 2024 15:41:01 GMT, Roger Riggs wrote:
> After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411), java.time
> implementation dependencies on doPriviledged and AccessController are removed.
> Some refactoring to cleanup the remaining code is expected.
This pul
> After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411),
> Serialization implementation dependencies on doPriviledged and
> AccessController are removed.
> Some refactoring to cleanup the remaining code is expected.
Roger Riggs has updated the pull request incrementa
> After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411),
> Serialization implementation dependencies on doPriviledged and
> AccessController are removed.
> Some refactoring to cleanup the remaining code is expected.
Roger Riggs has updated the pull request incrementa
After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411), Serialization
implementation dependencies on doPriviledged and AccessController are removed.
Some refactoring to cleanup the remaining code is expected.
-
Commit messages:
- Merge branch 'master' into 8344039-sm-clean
On Tue, 22 Oct 2024 22:17:11 GMT, Naoto Sato wrote:
>> This is a regression caused by the fix to
>> [JDK-8321206](https://bugs.openjdk.org/browse/JDK-8321206), where the
>> default locale with `user.region` creation is inadvertently broken. Fix is
>> to restore the user.region override within
On Wed, 23 Oct 2024 02:06:20 GMT, Joe Darcy wrote:
> Noticed this refactoring opportunity while doing some other work in the area.
lgtm
-
Marked as reviewed by rriggs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21652#pullrequestreview-2389308583
On Tue, 22 Oct 2024 18:09:57 GMT, Naoto Sato wrote:
> This is a regression caused by the fix to
> [JDK-8321206](https://bugs.openjdk.org/browse/JDK-8321206), where the default
> locale with `user.region` creation is inadvertently broken. Fix is to restore
> the user.region override within Stat
On Thu, 17 Oct 2024 20:11:16 GMT, Justin Lu wrote:
>> Please review this PR which specifies the _j.text.MessageFormat_
>> ArgumentIndex limit. A corresponding CSR is drafted.
>>
>> Both the existence of the limit (and behavior if violated), as well as this
>> implementation's limit are added t
On Wed, 16 Oct 2024 22:48:58 GMT, Justin Lu wrote:
> Please review this PR which specifies the _j.text.MessageFormat_
> ArgumentIndex limit. A corresponding CSR is drafted.
>
> Both the existence of the limit (and behavior if violated), as well as this
> implementation's limit are added to the
On Fri, 23 Aug 2024 17:54:55 GMT, Roger Riggs wrote:
>> Fixing an issue wrt wrong plural suffix with compact format for some
>> locales. It was retrieving the suffix based on the value before the
>> rounding, which ended up in wrong plural expression.
>
> src/java.base
On Thu, 22 Aug 2024 16:14:08 GMT, Naoto Sato wrote:
> Fixing an issue wrt wrong plural suffix with compact format for some locales.
> It was retrieving the suffix based on the value before the rounding, which
> ended up in wrong plural expression.
lgtm
-
Marked as reviewed by rri
On Thu, 22 Aug 2024 16:14:08 GMT, Naoto Sato wrote:
> Fixing an issue wrt wrong plural suffix with compact format for some locales.
> It was retrieving the suffix based on the value before the rounding, which
> ended up in wrong plural expression.
src/java.base/share/classes/java/text/CompactN
On Fri, 19 Jul 2024 09:52:50 GMT, Andrey Turbanov wrote:
> A few methods in `java.time.chrono.ChronoLocalDateImpl` are unused and could
> be removed:
> 1. plusWeeks(long)
> 2. minusYears(long)
> 3. minusMonths(long)
> 4. minusWeeks(long)
> 5. minusDays(long)
>
> Tested `test/jdk/java/time` on L
On Fri, 19 Jul 2024 09:52:50 GMT, Andrey Turbanov wrote:
> A few methods in `java.time.chrono.ChronoLocalDateImpl` are unused and could
> be removed:
> 1. plusWeeks(long)
> 2. minusYears(long)
> 3. minusMonths(long)
> 4. minusWeeks(long)
> 5. minusDays(long)
>
> Tested `test/jdk/java/time` on L
On Fri, 26 Jul 2024 15:53:11 GMT, Andriy Plokhotnyuk wrote:
> Could you please review [these](https://github.com/openjdk/jdk/pull/11986)
> proposed changes for instantiation of `Instant` values with already
> normalized nanos?
@plokhotnyuk Your contribution cannot be acted upon until the OCA i
On Sat, 6 Jul 2024 00:15:04 GMT, Shaojin Wen wrote:
>> String.format is widely used, and improving its performance is very
>> meaningful. This PR can significantly improve the performance of
>> String.format. Sorry, there are many changes, which will take a lot of time.
>> I hope you can revie
On Thu, 18 Jul 2024 23:36:37 GMT, Shaojin Wen wrote:
> The StringBuilder.repeat method was added in JDK 21, which can be used to
> make some minor optimizations to existing code, including
> DateTimeFormatterBuilder
lgtm
-
Marked as reviewed by rriggs (Reviewer).
PR Review: http
On Fri, 19 Jul 2024 13:03:31 GMT, Chen Liang wrote:
>> lingjun-cg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 896: Use StringBuilder internally for java.text.Format.* formatting
>
> src/java.base/share/classes/java/text/Format.ja
On Mon, 1 Jul 2024 19:17:50 GMT, Shaojin Wen wrote:
>> We need a String format solution with good performance. String Template was
>> once expected, but it has been removed. j.u.Formatter is powerful, but its
>> performance is not good enough.
>>
>> This PR implements a subset of j.u.Formatter
On Fri, 10 May 2024 09:22:39 GMT, serhiysachkov wrote:
>> Calendar.add() tests that describe its behavior.
>
> serhiysachkov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8331646 fixing typo
A bit late but the descriptions of the pro
On Fri, 3 May 2024 10:31:14 GMT, serhiysachkov wrote:
> Calendar.add() tests that describe its behavior.
The bug report and/or the PR description should describe the change in more
detail.
What conditions of the Calendar spec are being tested. Thanks
-
PR Comment: https://git.ope
On Mon, 22 Apr 2024 14:11:41 GMT, Claes Redestad wrote:
>> This switch expression in `Locale::createLocale` is causing a somewhat large
>> startup regression on my local system. Desugaring to if statements seem like
>> the right thing to do while we investigate ways to further reduce overheads
On Wed, 10 Apr 2024 16:17:32 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8212895?
>>
>> As noted in that issue, the `ChronoField.INSTANT_SECONDS` currently is
>> initialized to have a minim
On Tue, 9 Apr 2024 08:34:39 GMT, Jaikiran Pai wrote:
>> Should `INSTANT_SECONDS("InstantSeconds", SECONDS, FOREVER,
>> ValueRange.of(Instant.MIN.getEpochSecond(), Instant.MAX.getEpochSecond())),
>> ` work?
>
> Hello Naoto, that's a very good point. I was too caught up with the constant
> values
On Tue, 9 Apr 2024 08:37:29 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8212895?
>>
>> As noted in that issue, the `ChronoField.INSTANT_SECONDS` currently is
>> initialized to have a minimu
On Mon, 8 Apr 2024 18:00:02 GMT, Naoto Sato wrote:
>> Can I please get a review of this change which proposes to fix the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8212895?
>>
>> As noted in that issue, the `ChronoField.INSTANT_SECONDS` currently is
>> initialized to have a minimum
On Thu, 7 Mar 2024 19:28:13 GMT, Naoto Sato wrote:
> A simple doc update to include a leap day example in the `Calendar` class.
Marked as reviewed by rriggs (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18158#pullrequestreview-1925260836
On Wed, 6 Mar 2024 21:32:11 GMT, Naoto Sato wrote:
> Fixing timeout failures in the test case. Time zone names that are missing
> (chiefly for minor locales) are now calculated at runtime after the fix to
> JDK-8174269. This extra calculation time was multiplied in the test case as
> it iterat
On Sat, 2 Mar 2024 00:34:32 GMT, Justin Lu wrote:
> Please review this PR and corresponding CSR which prevents an
> OutOfMemoryError by restricting the initial maximum fraction digits for an
> empty pattern DecimalFormat.
>
> For an empty String pattern DecimalFormat, the maximum fraction digi
On Fri, 1 Mar 2024 21:29:17 GMT, Naoto Sato wrote:
>> This is stemming from the PR: https://github.com/openjdk/jdk/pull/14211
>> where aggressive GC can cause NPE in `BaseLocale$Key` class. I refactored
>> the in-house cache with WeakHashMap, and removed the Key class as it is no
>> longer nee
On Thu, 8 Feb 2024 21:29:19 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319344)
>> which adds MessageFormat pattern support for the following subformats:
>> ListFormat, CompactNumberFormat, and DateTimeFormatter. This change is
>> intended to p
On Wed, 7 Feb 2024 00:48:30 GMT, Naoto Sato wrote:
>> One idea would be to delegate to a (package-private) method in the formatXXX
>> class.
>> That would localize to the respective class the details.
>> (An abstract protected method might be preferred, but its not worth creating
>> extra publ
On Tue, 6 Feb 2024 22:31:32 GMT, Justin Lu wrote:
>> src/java.base/share/classes/java/text/MessageFormat.java line 681:
>>
>>> 679: if (fmt instanceof NumberFormat) {
>>> 680: // Add any instances returned from the NumberFormat
>>> factory methods
>>> 681: if (fm
On Fri, 2 Feb 2024 22:24:49 GMT, Naoto Sato wrote:
>> We discussed this separately, but will go over again here in case others are
>> interested. Since DTF does not implement `equals()`, even if we implement
>> `equals()` for the `ClassicFormat`, we would basically still need to
>> implement o
On Mon, 5 Feb 2024 23:51:00 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319344)
>> which adds MessageFormat pattern support for the following subformats:
>> ListFormat, CompactNumberFormat, and DateTimeFormatter. This change is
>> intended to p
On Fri, 2 Feb 2024 21:08:33 GMT, Joe Wang wrote:
> You are right, Joe. Apps using `java.time` formatters would still need to
> make changes to their code base. However, the bar is significantly lower.
> They would have to write some ugly workaround without this fix.
I'd also expect that applic
On Thu, 25 Jan 2024 21:38:54 GMT, Archie Cobbs wrote:
>> Please consider this fix to ensure that going from `MessageFormat` to
>> pattern string via `toPattern()` and then back via `new MessageFormat()`
>> results in a format that is equivalent to the original.
>>
>> The quoting and escaping r
On Fri, 12 Jan 2024 22:41:46 GMT, Justin Lu wrote:
>> Please review this PR which implements toString() for the `Format`
>> subclasses. Corresponding CSR:
>> [JDK-8323088](https://bugs.openjdk.org/browse/JDK-8323088)
>>
>> The general specification follows a template that provides the locale (
On Fri, 12 Jan 2024 19:07:46 GMT, Justin Lu wrote:
>> Please review this PR which implements toString() for the `Format`
>> subclasses. Corresponding CSR:
>> [JDK-8323088](https://bugs.openjdk.org/browse/JDK-8323088)
>>
>> The general specification follows a template that provides the locale (
On Tue, 9 Jan 2024 20:01:28 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflects review comments
>
> src/java.base/share/classes/java/lang/System.java line 819:
>
>> 817: *
>> 818: * Add
On Tue, 9 Jan 2024 19:23:53 GMT, Naoto Sato wrote:
>> Adding an explanation of the locale-related system properties in the
>> `System.getProperties()` method. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since th
1 - 100 of 225 matches
Mail list logo
