Re: RFR: 8356977: UTF-8 cleanups

2025-05-22 Thread Phil Race
On Wed, 14 May 2025 14:23:31 GMT, Magnus Ihse Bursie wrote: > I found a few other places in the code that can be cleaned up after the > conversion to UTF-8. src/java.desktop/share/classes/java/awt/MenuShortcut.java line 49: > 47: * For example, a menu shortcut for "Ctrl+cyrillic ef" is create

Re: RFR: 8356978: Convert unicode sequences in Java source code to UTF-8

2025-05-22 Thread Phil Race
On Wed, 14 May 2025 14:29:23 GMT, Magnus Ihse Bursie wrote: > After we converted the source base to be fully UTF-8, we do not need to use > unicode sequences (like \u0123) in string literals. Sometimes, that might > still make sense, as for control characters, non-breaking space, etc. But for

Re: RFR: 8356980: Better handling of non-breaking space

2025-05-22 Thread Phil Race
On Thu, 15 May 2025 12:33:06 GMT, Raffaello Giulietti wrote: >>> maybe this is just a translation error and a simple space can be used >>> instead, like in all the other properties in these files? >> >> That seems unlikely. The pattern is used consistently in the French >> translations, where

Re: RFR: 8357281: sun.util.Locale.LanguageTag should be immutable [v3]

2025-05-22 Thread Chen Liang
On Thu, 22 May 2025 17:51:32 GMT, Justin Lu wrote: >> _sun.util.Locale.LanguageTag_ is essentially a BCP47 language tag data >> carrier for Locale. The class, once created is not modified; the class >> should be made immutable. Converting the class to a record accomplishes this >> and also sim

Re: RFR: 8357281: sun.util.Locale.LanguageTag should be immutable [v3]

2025-05-22 Thread Naoto Sato
On Thu, 22 May 2025 17:51:32 GMT, Justin Lu wrote: >> _sun.util.Locale.LanguageTag_ is essentially a BCP47 language tag data >> carrier for Locale. The class, once created is not modified; the class >> should be made immutable. Converting the class to a record accomplishes this >> and also sim

Re: RFR: 8357281: sun.util.Locale.LanguageTag should be immutable [v2]

2025-05-22 Thread Justin Lu
On Thu, 22 May 2025 17:14:03 GMT, Chen Liang wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> review: subtag -> subtags, switch on baseLang, improve fragility of list >> field accessors > > src/java.base/share/classes

Re: RFR: 8357281: sun.util.Locale.LanguageTag should be immutable [v2]

2025-05-22 Thread Chen Liang
On Thu, 22 May 2025 16:46:10 GMT, Justin Lu wrote: >> _sun.util.Locale.LanguageTag_ is essentially a BCP47 language tag data >> carrier for Locale. The class, once created is not modified; the class >> should be made immutable. Converting the class to a record accomplishes this >> and also sim

Re: RFR: 8357281: sun.util.Locale.LanguageTag should be immutable [v3]

2025-05-22 Thread Justin Lu
> _sun.util.Locale.LanguageTag_ is essentially a BCP47 language tag data > carrier for Locale. The class, once created is not modified; the class should > be made immutable. Converting the class to a record accomplishes this and > also simplifies some of the existing code. Justin Lu has updated

Re: RFR: 8357281: sun.util.Locale.LanguageTag should be immutable [v2]

2025-05-22 Thread Steven Loomis
On Thu, 22 May 2025 16:46:10 GMT, Justin Lu wrote: >> _sun.util.Locale.LanguageTag_ is essentially a BCP47 language tag data >> carrier for Locale. The class, once created is not modified; the class >> should be made immutable. Converting the class to a record accomplishes this >> and also sim

Re: RFR: 8357281: sun.util.Locale.LanguageTag should be immutable [v2]

2025-05-22 Thread Justin Lu
> _sun.util.Locale.LanguageTag_ is essentially a BCP47 language tag data > carrier for Locale. The class, once created is not modified; the class should > be made immutable. Converting the class to a record accomplishes this and > also simplifies some of the existing code. Justin Lu has updated

Re: RFR: 8357281: sun.util.Locale.LanguageTag should be immutable

2025-05-22 Thread Justin Lu
On Wed, 21 May 2025 21:19:36 GMT, Justin Lu wrote: > _sun.util.Locale.LanguageTag_ is essentially a BCP47 language tag data > carrier for Locale. The class, once created is not modified; the class should > be made immutable. Converting the class to a record accomplishes this and > also simplif