Re: RFR: 8353322: Specification of ChoiceFormat#parse(String, ParsePosition) is inadequate [v3]

2025-04-02 Thread Alan Bateman
On Wed, 2 Apr 2025 19:43:29 GMT, Justin Lu wrote: >> src/java.base/share/classes/java/text/ChoiceFormat.java line 562: >> >>> 560: /** >>> 561: * Parses a {@code Number} from the input text, the subtype of >>> which is always >>> 562: * {@code Double}. The value returned is the {@

Re: RFR: 8353322: Specification of ChoiceFormat#parse(String, ParsePosition) is inadequate [v4]

2025-04-02 Thread Naoto Sato
On Wed, 2 Apr 2025 19:46:12 GMT, Justin Lu wrote: >> Please review this PR which specifies the `ChoiceFormat#parse(String, >> ParsePosition)` method. A corresponding CSR is filed. The current >> specification is simply "Parses a Number from the input text" which does not >> indicate how the va

Re: RFR: 8353322: Specification of ChoiceFormat#parse(String, ParsePosition) is inadequate [v3]

2025-04-02 Thread Justin Lu
On Wed, 2 Apr 2025 10:05:04 GMT, Alan Bateman wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address further comments > > src/java.base/share/classes/java/text/ChoiceFormat.java line 562: > >> 560: /** >> 561:

Re: RFR: 8353322: Specification of ChoiceFormat#parse(String, ParsePosition) is inadequate [v4]

2025-04-02 Thread Justin Lu
> Please review this PR which specifies the `ChoiceFormat#parse(String, > ParsePosition)` method. A corresponding CSR is filed. The current > specification is simply "Parses a Number from the input text" which does not > indicate how the value is returned. The criteria for a match, as well as no

Re: RFR: 8353322: Specification of ChoiceFormat#parse(String, ParsePosition) is inadequate [v3]

2025-04-02 Thread Alan Bateman
On Tue, 1 Apr 2025 20:32:45 GMT, Justin Lu wrote: >> Please review this PR which specifies the `ChoiceFormat#parse(String, >> ParsePosition)` method. A corresponding CSR is filed. The current >> specification is simply "Parses a Number from the input text" which does not >> indicate how the va