Re: RFR: 8289220: Locale.forLanguageTag throws NPE due to soft ref used in locale cache being cleared [v3]

2023-06-06 Thread SUN Guoyun
On Tue, 6 Jun 2023 18:45:50 GMT, Erik Österlund wrote: >> For hotspot, when GC occurs, it causes all threads to run to the nearest >> safepoint and then freeze. Generally, safepoints are generated at branch >> jumps, method ends(ret instructions), loops instructions, and so on. >> Therefore, t

Re: RFR: 8289220: Locale.forLanguageTag throws NPE due to soft ref used in locale cache being cleared [v6]

2023-06-06 Thread SUN Guoyun
> command: make test CONF=fastdebug JTREG="VM_OPTIONS=-Xcomp" > TEST=gc/TestAllocHumongousFragment.java > error info: > > Caused by: java.lang.NullPointerException: Cannot invoke > "sun.util.locale.BaseLocale.getVariant()" because "base" is null > at java.base/java.util.Locale.forLanguageTag(Lo

Re: RFR: 8289220: Locale.forLanguageTag throws NPE due to soft ref used in locale cache being cleared [v3]

2023-06-06 Thread Stuart Marks
On Tue, 6 Jun 2023 18:48:35 GMT, John R Rose wrote: >> This reasoning seems invalid. There are method calls in there, and you rely >> on inlining heuristics for this not to break. Please use reachabilityFence >> instead. > > It appears you are assuming that some combination of bytecodes constit

Re: RFR: 8289220: Locale.forLanguageTag throws NPE due to soft ref used in locale cache being cleared [v5]

2023-06-06 Thread SUN Guoyun
> command: make test CONF=fastdebug JTREG="VM_OPTIONS=-Xcomp" > TEST=gc/TestAllocHumongousFragment.java > error info: > > Caused by: java.lang.NullPointerException: Cannot invoke > "sun.util.locale.BaseLocale.getVariant()" because "base" is null > at java.base/java.util.Locale.forLanguageTag(Lo

Re: RFR: 8289220: Locale.forLanguageTag throws NPE due to soft ref used in locale cache being cleared [v3]

2023-06-06 Thread John R Rose
On Tue, 6 Jun 2023 18:45:50 GMT, Erik Österlund wrote: >> For hotspot, when GC occurs, it causes all threads to run to the nearest >> safepoint and then freeze. Generally, safepoints are generated at branch >> jumps, method ends(ret instructions), loops instructions, and so on. >> Therefore, t

Re: RFR: 8289220: Locale.forLanguageTag throws NPE due to soft ref used in locale cache being cleared [v3]

2023-06-06 Thread Erik Österlund
On Tue, 6 Jun 2023 02:31:19 GMT, SUN Guoyun wrote: >> I still don't see a clear explanation of how the proposed patch fixes the >> problem. Also, I would appreciate the reasoning in the comments. > > For hotspot, when GC occurs, it causes all threads to run to the nearest > safepoint and then f

Withdrawn: JDK-8303950: [macos]Translucent Windows Flicker on Repaint

2023-06-06 Thread duke
On Sun, 12 Mar 2023 17:35:40 GMT, Jeremy wrote: > I'm confident about the new test case for this ticket, but the resolution is > more invasive than I'd like. (It works, though.) > > In short: > This introduces a new RenderingHint (in SunHints) to bypass the call in > Window to `gg2d.fillRect(0