RFR: 8154520: java.time: appendLocalizedOffset() should return the localized "GMT" string

2019-06-28 Thread Thejasvi Voniadka
Hi, Request you to please review this change. JBS:https://bugs.openjdk.java.net/browse/JDK-8154520 Description:At present, the "DateTimeFormatterBuilder.appendLocalizedOffset()" method formulates the base string as "GMT", without accounting for locale-specific transformations. This

Re: RFR: 8154520: java.time: appendLocalizedOffset() should return the localized "GMT" string

2019-07-02 Thread Thejasvi Voniadka
. -Original Message- From: Naoto Sato Sent: Monday, July 01, 2019 9:02 PM To: Thejasvi Voniadka ; core-libs-...@openjdk.java.net; i18n-dev@openjdk.java.net Subject: Re: RFR: 8154520: java.time: appendLocalizedOffset() should return the localized "GMT" string Hi Thejasvi,

Re: RFR: 8154520: java.time: appendLocalizedOffset() should return the localized "GMT" string

2019-07-03 Thread Thejasvi Voniadka
TestLocalizedOffsetPrinterParser.java. -Original Message- From: Naoto Sato Sent: Tuesday, July 02, 2019 9:33 PM To: Thejasvi Voniadka ; core-libs-...@openjdk.java.net; i18n-dev@openjdk.java.net Subject: Re: RFR: 8154520: java.time: appendLocalizedOffset() should return the localized &quo

Re: RFR: 8154520: java.time: appendLocalizedOffset() should return the localized "GMT" string

2019-07-04 Thread Thejasvi Voniadka
Hi Roger,   Thank you for the review. I am in transit this weekend, but I will fix this and republish as soon as I can.     From: Roger Riggs Sent: Wednesday, July 03, 2019 10:46 PM To: Thejasvi Voniadka ; core-libs-...@openjdk.java.net; i18n-dev@openjdk.java.net Subject: Re: RFR: 8154520

Re: RFR: 8154520: java.time: appendLocalizedOffset() should return the localized "GMT" string

2019-07-09 Thread Thejasvi Voniadka
/format/TestLocalizedOffsetPrinterParser.java. That should provide sufficient coverage towards the functionality. -Original Message- From: Thejasvi Voniadka Sent: Friday, July 05, 2019 9:16 AM To: Roger Riggs ; core-libs-...@openjdk.java.net; i18n-dev@openjdk.java.net Subject: RE: RFR

RFR: 8160225: java.time.format.DateTimeFormatter issues for month-of-year

2019-07-30 Thread Thejasvi Voniadka
Hi, Request your review of this simple change. JBS:https://bugs.openjdk.java.net/browse/JDK-8160225 (java.time.format.DateTimeFormatter issues for month-of-year) Description:It is a simple documentation change. The DateTimeFormatter expects the month format to be represented by "L" for

Re: RFR: 8160225: java.time.format.DateTimeFormatter issues for month-of-year

2019-07-30 Thread Thejasvi Voniadka
: Naoto Sato Sent: Tuesday, July 30, 2019 9:39 PM To: Thejasvi Voniadka ; core-libs-...@openjdk.java.net; i18n-dev@openjdk.java.net Subject: Re: RFR: 8160225: java.time.format.DateTimeFormatter issues for month-of-year Hi Thejasvi, M/L does not designate textual nor numeric. Thus I don't think

RFR: 8158880: test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale

2019-08-01 Thread Thejasvi Voniadka
Hi, Request you to please review this change. JBS:https://bugs.openjdk.java.net/browse/JDK-8158880 (test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale) Description:The test " test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java#

Re: RFR: 8158880: test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale

2019-08-07 Thread Thejasvi Voniadka
Hi Naoto, Thank you for the review. This change has now been pushed. -Original Message- From: Naoto Sato Sent: Thursday, August 01, 2019 9:43 PM To: Thejasvi Voniadka ; i18n-dev@openjdk.java.net; core-libs-...@openjdk.java.net Subject: Re: RFR: 8158880: test/java/time/tck/java/time