On Tue, 22 Mar 2022 18:44:09 GMT, Naoto Sato wrote:
> Fixing the out-of-date number of entries in
> `Character.UnicodeBlock.NUM_ENTITIES` field. The regression test has been
> renamed and now repurposed just to examine whether the `NUM_ENTITIES`
> correctly has the `map.size()` value.
Thanks
On Tue, 22 Mar 2022 22:02:22 GMT, Naoto Sato wrote:
>> Fixing the out-of-date number of entries in
>> `Character.UnicodeBlock.NUM_ENTITIES` field. The regression test has been
>> renamed and now repurposed just to examine whether the `NUM_ENTITIES`
>> correctly has the `map.size()` value.
>
>
On Tue, 22 Mar 2022 21:58:27 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/lang/Character.java line 740:
>>
>>> 738: public static final class UnicodeBlock extends Subset {
>>> 739: /**
>>> 740: * 737 - the expected number of entities
>>
>> Just a quibble about
On Thu, 24 Mar 2022 22:01:30 GMT, Naoto Sato wrote:
> Proposing to deprecate the constructors in the `java.util.Locale` class.
> There is already a factory method and a builder to return singletons, so
> there is no need to have constructors anymore unless one purposefully wants
> to create `i
On Wed, 13 Apr 2022 16:29:11 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> revert changes in:
> src/java.desktop
> src/java.management
> src/jdk
On Wed, 13 Apr 2022 22:20:14 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update LastModified
src/java.base/share/classes/java/lang/Character.java l
On Wed, 13 Apr 2022 22:20:14 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update LastModified
src/java.xml/share/classes/com/sun/org/apache/xalan/in
On Wed, 13 Apr 2022 22:20:14 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update LastModified
src/java.xml/share/classes/com/sun/org/apache/xerces/i
On Wed, 13 Apr 2022 22:20:14 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update LastModified
src/java.base/unix/classes/java/lang/ProcessEnvironmen
On Wed, 13 Apr 2022 20:06:34 GMT, Naoto Sato wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> revert changes in:
>> src/java.desktop
>> src/java.management
>> src/jdk.internal.vm.ci
>> src/jdk.jfr
>> src/jdk.
On Thu, 14 Apr 2022 19:53:45 GMT, Bradford Wetmore wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add `@LastModified: Apr 2022` to DocumentCache
>
> I learned something new about HashMap today...
>
> I looked at jav
On Thu, 14 Apr 2022 22:27:20 GMT, Naoto Sato wrote:
>> Added the test case, and eliminated the immediate hashmap value, replaced
>> with the ordinal number of `Character.UnicodeScript.UNKNOWN`.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last
On Thu, 14 Apr 2022 20:16:38 GMT, Sean Mullan wrote:
>>> Are the changes necessary for this part?
>>
>> @seanjmullan no, they are just performance refinement.
>>
>> If you really that wanna 100% sync ,
>>
>> I can use the old 1.8 api to migrate that part, and make a mirror pr to that
>> part
On Thu, 14 Apr 2022 21:27:16 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> java.xml.crypto's usage downgrade grammar to 1.8
Marked as reviewed by sma
On Thu, 14 Apr 2022 21:27:16 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> java.xml.crypto's usage downgrade grammar to 1.8
I've also written a relea
On Fri, 27 May 2022 18:40:32 GMT, XenoAmess wrote:
>> as title.
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> do it as naotoj said
Reviewers for i18n, net, nio, and security, please review call site changes in
your areas.
On Wed, 8 Jun 2022 17:49:38 GMT, XenoAmess wrote:
>> as title.
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> clean up Calendar
Running tests and awaiting review from security team. Our internal test system
is backlogged an
Hi Francis,
Alan Bateman directed me to this patch since it includes changes to the RMI
tests, which I maintain. I have a few comments on the changes to these tests.
From: Francis ANDRE
Following are a list of patch for making the jdk jtreg test suite happy with a
WXP/Cygwin/VS2010 Franch
On 10/31/13 9:44 PM, Francis ANDRE wrote:
Le 31/10/2013 22:27, Stuart Marks a écrit :
It turns out that the debugExec lines emitted by rmid are localized:
If the lines emitted by rmid are localized, then your test "s.indexOf("rmid:
debugExec") != -1" should be also loc
On 11/4/13 7:39 PM, Francis ANDRE wrote:
Stuart. the jtreg jdk test should pass OK on all platforms where OpenJDK could
be build.
Yes. On this, we agree. At least, all the tests should pass, on platforms and
locales that OpenJDK supports. It looks like localizations are present in
OpenJDK f
On 11/5/13 10:31 PM, Francis ANDRE wrote:
To add a little bit more of clarity for the i18n problems in the ResourceBundle
tests, joined is an extract from the log of their failures before I fixed them
for the non US Locale case. Sorry for not having joined this log before.
By the way, it looks
Hi Naoto,
The changes look sensible, though I'm not an expert in the ResourceBundle API.
I did notice though that in ResourceBundleTest.java there is a static import of
java.util.ResourceBundle.Control. Does it need to be a static import?
Surprisingly, it seems to compile either way.
s'marks
Hm, interesting, good catch Peter! Very subtle. The time-honored
(int) (expected / 0.75f) + 1
appears in several places around the JDK. I think most people (including me)
just copy it, because it's "good enough" for most cases.
I'm a little concerned about
(expectedSize * 4 + 2) / 3
On Fri, 11 Sep 2020 15:17:58 GMT, Bradford Wetmore wrote:
>> Ok, sorry for the distraction.
>
> Our local Santuario maintainer says:
>
> In general, changes to Apache Santuario should also be made at Apache so we
> stay in sync.
Hi @doom369, I hope we didn't end up wasting too much of your tim
On Tue, 17 Nov 2020 21:21:47 GMT, Roger Riggs wrote:
>> Ian Graves has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adding test coverage. Tweaking wording in docs.
>
> test/jdk/java/util/IllegalFormatException/ArgumentIndexException.java
On Wed, 18 Nov 2020 22:57:19 GMT, Ian Graves wrote:
>> The `java.util.Formatter` format specifies support for field widths,
>> argument indexes, or precision lengths of a field that relate to the
>> variadic arguments supplied to the formatter. These numbers are specified by
>> integers, somet
On Thu, 19 Nov 2020 00:58:21 GMT, Ian Graves wrote:
>> The `java.util.Formatter` format specifies support for field widths,
>> argument indexes, or precision lengths of a field that relate to the
>> variadic arguments supplied to the formatter. These numbers are specified by
>> integers, somet
On Tue, 15 Dec 2020 09:17:03 GMT, Magnus Ihse Bursie wrote:
>> Your call, I'm not a native English speaker :-) It felt to me it's
>> 'restrictive' than 'restrictively', an adj placed after the noun, e.g. a
>> restrictive allow-list.
>
> It's an adverb, since it's the act of 'defining' that is
On Tue, 15 Dec 2020 23:14:14 GMT, Brent Christian wrote:
>> This is part of an effort in the JDK to replace archaic/non-inclusive words
>> with more neutral terms (see JDK-8253315 for details).
>>
>> Here are the changes covering core libraries code and tests. Terms were
>> changed as follows
On Wed, 16 Dec 2020 20:08:11 GMT, Brent Christian wrote:
>> This is part of an effort in the JDK to replace archaic/non-inclusive words
>> with more neutral terms (see JDK-8253315 for details).
>>
>> Here are the changes covering core libraries code and tests. Terms were
>> changed as follows
Tighten up argument checking in constructor.
-
Commit messages:
- 8246788: ZoneRules invariants can be broken
Changes: https://git.openjdk.java.net/jdk/pull/2191/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2191&range=00
Issue: https://bugs.openjdk.java.net/browse/
On Fri, 22 Jan 2021 17:12:34 GMT, Daniel Fuchs wrote:
>> Or even maybe `rulesArray =
>> lastRules.toArray(ZoneOffsetTransitionRule[]::new);`?
>
> Good point - but that would be:
>
> ZoneOffsetTransitionRule[] rulesArray =
> lastRules.toArray(ZoneOffsetTransitionRule[]::new).clone();
Interesti
On Fri, 22 Jan 2021 05:39:55 GMT, Stuart Marks wrote:
> Tighten up argument checking in constructor.
This pull request has now been integrated.
Changeset: a8871776
Author: Stuart Marks
URL: https://git.openjdk.java.net/jdk/commit/a8871776
Stats: 90 lines in 2 files changed:
On Wed, 3 Feb 2021 22:42:00 GMT, Ian Graves wrote:
> Updating the specification to reflect well-established behavior in Formatter
> when incorrect flags used for `%`.
Marked as reviewed by smarks (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2389
On Mon, 8 Mar 2021 18:48:30 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.io`,
> `java.math`, and `java.text` packages to make use of the `instanceof` pattern
> variable?
>
> Kind regards,
> Patrick
Marked as reviewed by smark
On Wed, 24 Mar 2021 23:17:46 GMT, Joe Darcy wrote:
> 8264148: Update spec for exceptions retrofitted for exception chaining
The removal of the obsolescent "As of release 1.4, this exception has been
retrofitted..." is good. Changing the calls from the other exception-getting
methods to `getCau
On Wed, 24 Mar 2021 23:17:46 GMT, Joe Darcy wrote:
> 8264148: Update spec for exceptions retrofitted for exception chaining
Marked as reviewed by smarks (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3182
On Fri, 16 Apr 2021 16:08:53 GMT, Ian Graves wrote:
>> This fixes a bug where the formatting code for `%g` flags incorrectly tries
>> to round `BigDecimal` after determining whether it should be a decimal
>> numeric format or a scientific numeric format. The solution rounds before
>> determini
On Fri, 20 Aug 2021 21:17:50 GMT, Ian Graves wrote:
>> 8271302: Regex Test Refresh
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Additional cleanup
Marked as reviewed by smarks (Reviewer).
Whew! Changes to GraphemeTest.ja
On Wed, 10 Nov 2021 19:05:17 GMT, Naoto Sato wrote:
>> This fix is to require to include `Locale.ROOT` in the returned arrays/set
>> from `getAvailableLocales()` methods in various locale-sensitive classes.
>> The implementation has been including `Locale.ROOT` since its inception, it
>> is si
On Wed, 1 Dec 2021 19:23:59 GMT, Brent Christian wrote:
>> Here are the code changes for the "Deprecate finalizers in the standard Java
>> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
>> review.
>>
>> This change makes the indicated deprecations, and updates the API
41 matches
Mail list logo