Re: [8u-dev] 8051641: Request for Approval: Africa/Casablanca transitions is incorrectly calculated starting from 2027

2015-01-05 Thread Rob McKenna
Approved pending codreview. -Rob On 28/12/14 11:02, Aleksej Efimov wrote: Hi, Can I have an approval for the backport of 8051641. The backport slightly differs from JDK9 for ZoneRulesBuilder.java. Adding the original reviewer and alias for review. Testing: All TZ related tests shows PASS

Re: [8u60] RFR: 7044727: (tz) TimeZone.getDefault() call returns incorrect value in Windows terminal session

2015-04-17 Thread Rob McKenna
Approved for push. -Rob On 18/04/15 00:05, Naoto Sato wrote: My only comment is that it could be confusing to use the same name "getDynamicTimeZoneInfo" for the function name and the proc address variable name (initially I thought if it were a recursive call). Otherwise it looks good to m