Hi,
Could someone please review my code for updating the code in the `java.io`,
`java.math`, and `java.text` packages to make use of the `instanceof` pattern
variable?
Kind regards,
Patrick
-
Commit messages:
- 8263190: Update java.io, java.math, and java.text to use instanceof p
On Mon, 8 Mar 2021 18:48:30 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.io`,
> `java.math`, and `java.text` packages to make use of the `instanceof` pattern
> variable?
>
> Kind regards,
> Patrick
T
Hi,
Could someone please review my code for updating the code in the `java.time`
package to make use of the `instanceof` pattern variable?
Kind regards,
Patrick
-
Commit messages:
- Merge remote-tracking branch 'origin/master' into JDK-8263668
- 8263668: Update java.time to use i
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a re
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a re
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a re
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a re
On Wed, 24 Mar 2021 13:57:35 GMT, Roger Riggs wrote:
> In addition to the other suggestions, java.time could use a round of cleanup
> to use switch expressions.
Hi Roger, I plan to introduce switch expressions in a follow up issue/PR.
-
PR: https://git.openjdk.java.net/jdk/pull/31
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request incrementally with one
additional commit si
On Mon, 19 Apr 2021 15:37:24 GMT, Roger Riggs wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request conta
On Wed, 24 Mar 2021 10:57:11 GMT, Rémi Forax
wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updated single letter pattern variable names
>
> src/java.base/share/classes/jav
On Wed, 24 Mar 2021 11:06:38 GMT, Rémi Forax
wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updated single letter pattern variable names
>
> src/java.base/
On Wed, 21 Apr 2021 09:06:45 GMT, Daniel Fuchs wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updated single letter pattern variable names
>
> src/java.base/share/classes/ja
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a re
On Wed, 21 Apr 2021 13:02:06 GMT, Andrey Turbanov
wrote:
> I was able to find (with IntelliJ IDEA help) few more places to improve
>
> ```
> java.time 27 warnings
> class Clock 2 warnings
> class FixedClock 1 warning
> method equals(Object) 1 w
On Wed, 24 Mar 2021 09:56:16 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
This pull request has now been i
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a re
On Wed, 21 Apr 2021 13:02:06 GMT, Andrey Turbanov
wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request cont
Hi,
Could someone please review the second half of my update for the `java.time`
package to make use of the `instanceof` pattern variable?
This PR was split into two parts due to the large number of files affected.
Kind regards,
Patrick
-
Commit messages:
- 8265746: Update java.
> Hi,
>
> Could someone please review the second half of my update for the `java.time`
> package to make use of the `instanceof` pattern variable?
>
> This PR was split into two parts due to the large number of files affected.
>
> Kind regards,
>
> Patrick
Pat
On Fri, 23 Apr 2021 14:29:36 GMT, Chris Hegarty wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
On Fri, 23 Apr 2021 10:44:30 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review the second half of my update for the `java.time`
> package to make use of the `instanceof` pattern variable?
>
> This PR was split into two parts due to the large number
Hi,
Could someone please review my code for updating the code in the `java.util`
package to make use of the `instanceof` pattern variable?
Kind regards,
Patrick
-
Commit messages:
- 8267110: Update java.util to use instanceof pattern variable
Changes: https://git.openjdk.java.net
> Hi,
>
> Could someone please review my code for updating the code in the `java.util`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a re
> Hi,
>
> Could someone please review my code for updating the code in the `java.util`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a re
> Hi,
>
> Could someone please review my code for updating the code in the `java.util`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request incrementally with one
additional commit si
> Hi,
>
> Could someone please review my code for updating the code in the `java.util`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a re
On Tue, 18 May 2021 10:37:21 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.util`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
This pull request has now been i
On Tue, 25 May 2021 06:01:49 GMT, Tagir F. Valeev wrote:
>> Inspired by PR#4088. Most of the changes are done automatically using
>> IntelliJ IDEA refactoring. Some manual adjustments are also performed,
>> including indentations, moving comments, extracting common cast out of
>> switch expres
Hi,
Could someone please review my code for updating the code in the `java.io`,
`java.math`, and `java.text` packages to make use of the switch expressions?
Kind regards,
Patrick
-
Commit messages:
- 8267670: Update java.io, java.math, and java.text to use switch expressions
Chan
> Hi,
>
> Could someone please review my code for updating the code in the `java.io`,
> `java.math`, and `java.text` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to
On Tue, 25 May 2021 12:31:38 GMT, Chris Hegarty wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
On Tue, 25 May 2021 13:16:00 GMT, Daniel Fuchs wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
On Tue, 25 May 2021 12:43:00 GMT, Naoto Sato wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
> Hi,
>
> Could someone please review my code for updating the code in the `java.io`,
> `java.math`, and `java.text` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request incrementally with one
additi
On Tue, 25 May 2021 15:18:46 GMT, Chris Hegarty wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
> Hi,
>
> Could someone please review my code for updating the code in the `java.io`,
> `java.math`, and `java.text` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request incrementally with one
additi
On Wed, 26 May 2021 09:05:34 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.io`,
>> `java.math`, and `java.text` packages to make use of the switch expressions?
>>
>> Kind regards,
>>
> Hi,
>
> Could someone please review my code for updating the code in the `java.io`,
> `java.math`, and `java.text` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to
> Hi,
>
> Could someone please review my code for updating the code in the `java.io`,
> `java.math`, and `java.text` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request incrementally with one
additi
> Hi,
>
> Could someone please review my code for updating the code in the `java.io`,
> `java.math`, and `java.text` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to
> Hi,
>
> Could someone please review my code for updating the code in the `java.io`,
> `java.math`, and `java.text` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to
> Hi,
>
> Could someone please review my code for updating the code in the `java.io`,
> `java.math`, and `java.text` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to
> Hi,
>
> Could someone please review my code for updating the code in the `java.io`,
> `java.math`, and `java.text` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to
On Tue, 25 May 2021 09:37:58 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.io`,
> `java.math`, and `java.text` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
This pull
Hi,
Could someone please review my code for updating the code in the `java.lang`
packages to make use of the switch expressions?
Kind regards,
Patrick
-
Commit messages:
- 8268124: Update java.lang to use switch expressions
Changes: https://git.openjdk.java.net/jdk/pull/4312/file
> Hi,
>
> Could someone please review my code for updating the code in the `java.lang`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a rebase. T
> Hi,
>
> Could someone please review my code for updating the code in the `java.lang`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request incrementally with one
additional commit since the last
On Wed, 2 Jun 2021 16:43:25 GMT, Naoto Sato wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8268124: small refactoring; fixed misplaced comment and added missing
>> lambda op
On Wed, 2 Jun 2021 16:06:42 GMT, Rémi Forax wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8268124: small refactoring; fixed misplaced comment and added missing
>> lambda op
On Thu, 3 Jun 2021 11:35:13 GMT, Rémi Forax wrote:
>> My mistake. I've replaced the colon now with the lambda operator. See a8706b0
>
>> My mistake. I've replaced the colon now with the lambda operator.
>
> Drive by comment, in term of name, `->` is the arrow operator not the lambda
> operator.
> Hi,
>
> Could someone please review my code for updating the code in the `java.lang`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a rebase. T
On Wed, 2 Jun 2021 16:10:19 GMT, Rémi Forax wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contai
On Thu, 3 Jun 2021 17:04:58 GMT, Mandy Chung wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8268124: small refactoring; fixed misplaced comment and added missing
>> lambda op
> Hi,
>
> Could someone please review my code for updating the code in the `java.lang`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request incrementally with two
additional commits since the last
Hi,
Could someone please review my code for updating the code in the `java.time`
packages to make use of the switch expressions?
Kind regards,
Patrick
-
Commit messages:
- 8268469: Update java.time to use switch expressions
Changes: https://git.openjdk.java.net/jdk/pull/4433/file
> Hi,
>
> Could someone please review my code for updating the code in the `java.lang`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a rebase. T
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a rebase. T
On Wed, 2 Jun 2021 15:25:16 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.lang`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
This pull request has now been integrated.
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a rebase. T
On Wed, 9 Jun 2021 22:03:54 GMT, Stephen Colebourne
wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contai
On Wed, 9 Jun 2021 16:25:55 GMT, Naoto Sato wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contai
On Wed, 9 Jun 2021 16:31:10 GMT, Daniel Fuchs wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contai
On Wed, 9 Jun 2021 22:11:59 GMT, Stephen Colebourne
wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contai
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a rebase. T
On Thu, 17 Jun 2021 13:51:27 GMT, Daniel Fuchs wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contai
On Wed, 16 Jun 2021 10:58:22 GMT, Stephen Colebourne
wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull req
Hi,
Could someone please review the second half of my update for the `java.time`
package to make use of switch expressions?
This PR was split into two parts due to the large number of files affected.
Kind regards,
Patrick
-
Commit messages:
- 8269124: Update java.time to use swi
On Tue, 22 Jun 2021 15:40:12 GMT, Aleksei Efimov wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8269124: Added missing brace; fixed build issue
>
> src/java.base/share/classes/j
> Hi,
>
> Could someone please review the second half of my update for the `java.time`
> package to make use of switch expressions?
>
> This PR was split into two parts due to the large number of files affected.
>
> Kind regards,
>
> Patrick
Patrick Concanno
> Hi,
>
> Could someone please review the second half of my update for the `java.time`
> package to make use of switch expressions?
>
> This PR was split into two parts due to the large number of files affected.
>
> Kind regards,
>
> Patrick
Patrick Concanno
On Tue, 22 Jun 2021 17:27:58 GMT, Naoto Sato wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8269124: Added missing brace; fixed build issue
>
> src/java.base/share/classes/j
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a rebase. T
> Hi,
>
> Could someone please review the second half of my update for the `java.time`
> package to make use of switch expressions?
>
> This PR was split into two parts due to the large number of files affected.
>
> Kind regards,
>
> Patrick
Patrick Concanno
On Wed, 23 Jun 2021 17:54:30 GMT, Daniel Fuchs wrote:
>> I'd personally replace all the applicable locations, as otherwise, it would
>> confuse why there are two idioms. But it is outside of this PR so probably
>> for another day.
>
> I agree with Naoto that it's a bit strange.
OK. If you guys
> Hi,
>
> Could someone please review the second half of my update for the `java.time`
> package to make use of switch expressions?
>
> This PR was split into two parts due to the large number of files affected.
>
> Kind regards,
>
> Patrick
Patrick Concanno
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a rebase. T
On Wed, 9 Jun 2021 15:41:59 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
This pull request has now been integrated.
> Hi,
>
> Could someone please review the second half of my update for the `java.time`
> package to make use of switch expressions?
>
> This PR was split into two parts due to the large number of files affected.
>
> Kind regards,
>
> Patrick
Patrick Concanno
On Tue, 22 Jun 2021 10:50:17 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review the second half of my update for the `java.time`
> package to make use of switch expressions?
>
> This PR was split into two parts due to the large number of files affected.
80 matches
Mail list logo
