On Wed, 13 Apr 2022 19:28:08 GMT, Stuart Marks wrote:
> Reviewers for i18n, net, nio, and security, please review call site changes
> in your areas. Thanks.
Changes to `java.net.http` look good to me. I haven't spotted anything
obviously wrong in the rest, but should defer to reviewers of thes
> Found various typos of expected: `exepected`, `exept`, `epectedly`,
> `expeced`, `Unexpeted`, etc.
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8284853: Fix various 'expected' typo
improve test log
-
Changes:
On Thu, 14 Apr 2022 09:28:17 GMT, Andrey Turbanov wrote:
>> Found various typos of expected: `exepected`, `exept`, `epectedly`,
>> `expeced`, `Unexpeted`, etc.
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8284853: Fi
On Thu, 14 Apr 2022 09:28:17 GMT, Andrey Turbanov wrote:
>> Found various typos of expected: `exepected`, `exept`, `epectedly`,
>> `expeced`, `Unexpeted`, etc.
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8284853: Fi
On Wed, 13 Apr 2022 22:20:14 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update LastModified
LGTM.
-
Marked as reviewed by chegar (Re
I ran `codespell` on the `make` directory, and accepted those changes where it
indeed discovered real typos.
(Due to false positives this can unfortunately not be run automatically)
Most of the fixes are in comments. A few are in messages aimed at the user.
-
Commit messages:
- 8
On Thu, 14 Apr 2022 16:05:48 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on the `make` directory, and accepted those changes where
> it indeed discovered real typos.
>
> (Due to false positives this can unfortunately not be run automatically)
>
> Most of the fixes are in comments. A fe
> 8186958: Need method to create pre-sized HashMap
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
fix usage in XSAttributeChecker
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7928/files
- new: https://git.op
On Thu, 14 Apr 2022 03:38:52 GMT, Joe Wang wrote:
>>> I suspect the `size*2+1` was a failed attempt at allocating a HashMap of
>>> the correct capacity for `size` mappings.
>>
>> I looked the codes and don't think so..
>> If I'm wrong, I'm glad to fix.
>
> Stuart's right, I looked at the code,
> 8186958: Need method to create pre-sized HashMap
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
revert changes on ProcessEnvironment
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7928/files
- new: https://g
On Wed, 13 Apr 2022 23:25:47 GMT, Stuart Marks wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update LastModified
>
> src/java.base/unix/classes/java/lang/ProcessEnvironment.java line 102:
>
>> 100: /* Only for
On Wed, 13 Apr 2022 22:53:15 GMT, Naoto Sato wrote:
> Good point! Filed an issue: https://bugs.openjdk.java.net/browse/JDK-8284856
@stuart-marks @naotoj I can help solve JDK-8284856 after this pr. But usually
we only solve 1 issue in 1 pr, so I think it's better to wait after this.
---
On Thu, 14 Apr 2022 17:05:39 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> revert changes on ProcessEnvironment
src/java.xml/share/classes/com/sun/or
On Wed, 13 Apr 2022 20:36:48 GMT, Andrey Turbanov wrote:
> Found various typos of expected: `exepected`, `exept`, `epectedly`,
> `expeced`, `Unexpeted`, etc.
This pull request has now been integrated.
Changeset: 48c75498
Author:Andrey Turbanov
URL:
https://git.openjdk.java.net/jdk/
On Thu, 14 Apr 2022 10:38:33 GMT, Yi Yang wrote:
>I found [yet another
>typo](https://github.com/kelthuzadx/jdk/commit/acb9e15bc0bf5395d1c0875f36992f692734f948),
> I wonder if you can merge this into your patch so that I do not need to
>submit a new PR for it? Thanks.
I think it deserves a sep
> 8186958: Need method to create pre-sized HashMap
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
add `@LastModified: Apr 2022` to DocumentCache
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7928/files
- new:
On Thu, 14 Apr 2022 17:23:42 GMT, Joe Wang wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> revert changes on ProcessEnvironment
>
> src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/DocumentCache.
On Thu, 14 Apr 2022 18:05:48 GMT, XenoAmess wrote:
>> src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/DocumentCache.java
>> line 3:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2015, 2022, Oracle and/or its affiliates. All rights
>>> reserved.
>>> 3: */
>>
>> The LastModified
On Thu, 14 Apr 2022 18:10:28 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add `@LastModified: Apr 2022` to DocumentCache
Marked as reviewed by joehw
On Thu, 14 Apr 2022 17:06:53 GMT, XenoAmess wrote:
>> Good point! Filed an issue: https://bugs.openjdk.java.net/browse/JDK-8284856
>
>> Good point! Filed an issue: https://bugs.openjdk.java.net/browse/JDK-8284856
>
> @stuart-marks @naotoj I can help solve JDK-8284856 after this pr. But usually
I ran `codespell` on the `src/java.base` directory, and accepted those changes
where it indeed discovered real typos.
(Due to false positives this can unfortunately not be run automatically)
The majority of fixes are in comments. A handful is in strings, one in a local
variable name, and a cou
On Thu, 14 Apr 2022 16:05:48 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on the `make` directory, and accepted those changes where
> it indeed discovered real typos.
>
> (Due to false positives this can unfortunately not be run automatically)
>
> Most of the fixes are in comments. A fe
On Thu, 14 Apr 2022 19:07:09 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on the `src/java.base` directory, and accepted those
> changes where it indeed discovered real typos.
>
> (Due to false positives this can unfortunately not be run automatically)
>
> The majority of fixes are in c
On Thu, 14 Apr 2022 18:10:28 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add `@LastModified: Apr 2022` to DocumentCache
Right, we generally try to
On Thu, 14 Apr 2022 18:10:28 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add `@LastModified: Apr 2022` to DocumentCache
I learned something new abo
On Thu, 14 Apr 2022 19:07:09 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on the `src/java.base` directory, and accepted those
> changes where it indeed discovered real typos.
>
> (Due to false positives this can unfortunately not be run automatically)
>
> The majority of fixes are in c
On Thu, 14 Apr 2022 18:10:28 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add `@LastModified: Apr 2022` to DocumentCache
> Are the changes necessary
On Thu, 14 Apr 2022 20:11:37 GMT, XenoAmess wrote:
> > Are the changes necessary for this part?
>
> @seanjmullan no, they are just performance refinement.
>
> If you really that wanna 100% sync ,
>
> I can use the old 1.8 api to migrate that part, and make a mirror pr to that
> part of https:
On Thu, 14 Apr 2022 19:07:09 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on the `src/java.base` directory, and accepted those
> changes where it indeed discovered real typos.
>
> (Due to false positives this can unfortunately not be run automatically)
>
> The majority of fixes are in c
On Thu, 14 Apr 2022 19:53:45 GMT, Bradford Wetmore wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add `@LastModified: Apr 2022` to DocumentCache
>
> I learned something new about HashMap today...
>
> I looked at jav
On Thu, 14 Apr 2022 18:32:03 GMT, Naoto Sato wrote:
>>> Good point! Filed an issue: https://bugs.openjdk.java.net/browse/JDK-8284856
>>
>> @stuart-marks @naotoj I can help solve JDK-8284856 after this pr. But
>> usually we only solve 1 issue in 1 pr, so I think it's better to wait after
>> thi
Added the test case, and eliminated the immediate hashmap value, replaced with
the ordinal number of `Character.UnicodeScript.UNKNOWN`.
-
Depends on: https://git.openjdk.java.net/jdk/pull/7928
Commit messages:
- 8284856: Add a test case for checking UnicodeScript entity numbers
Ch
> 8186958: Need method to create pre-sized HashMap
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
java.xml.crypto's usage downgrade grammar to 1.8
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7928/files
- ne
On Thu, 14 Apr 2022 19:56:22 GMT, Bradford Wetmore wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add `@LastModified: Apr 2022` to DocumentCache
>
> src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOM
On Thu, 14 Apr 2022 20:52:44 GMT, Naoto Sato wrote:
> Added the test case, and eliminated the immediate hashmap value, replaced
> with the ordinal number of `Character.UnicodeScript.UNKNOWN`.
Nice catch in the review for 8186958.
-
Marked as reviewed by iris (Reviewer).
PR: https
> Added the test case, and eliminated the immediate hashmap value, replaced
> with the ordinal number of `Character.UnicodeScript.UNKNOWN`.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Fixed a typo
-
Changes:
- all:
On Thu, 14 Apr 2022 22:27:20 GMT, Naoto Sato wrote:
>> Added the test case, and eliminated the immediate hashmap value, replaced
>> with the ordinal number of `Character.UnicodeScript.UNKNOWN`.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last
On Thu, 14 Apr 2022 22:27:20 GMT, Naoto Sato wrote:
>> Added the test case, and eliminated the immediate hashmap value, replaced
>> with the ordinal number of `Character.UnicodeScript.UNKNOWN`.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last
38 matches
Mail list logo
