Re: RFR: JDK-8282625 Formatter caches Locale/DecimalFormatSymbols poorly [v10]

2022-03-11 Thread Jim Laskey
On Fri, 11 Mar 2022 04:28:00 GMT, Jaikiran Pai wrote: >> Jim Laskey has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 14 additional >> commits sin

Re: RFR: JDK-8282625 Formatter caches Locale/DecimalFormatSymbols poorly [v10]

2022-03-11 Thread Jaikiran Pai
On Fri, 11 Mar 2022 10:16:33 GMT, Jim Laskey wrote: >> src/java.base/share/classes/java/text/DecimalFormatSymbols.java line 192: >> >>> 190: >>> 191: /** >>> 192: * {@return locale used to create this instance} >> >> Hello Jim, the opening and closing `{`, I think aren't needed for a

Re: RFR: JDK-8282625 Formatter caches Locale/DecimalFormatSymbols poorly [v10]

2022-03-11 Thread Jaikiran Pai
On Thu, 10 Mar 2022 18:34:27 GMT, Jim Laskey wrote: >> Several attempts have been made to improve Formatter's numeric performance >> by caching the current Locale zero. Such fixes, however, ignore the real >> issue, which is the slowness of fetching DecimalFormatSymbols. By directly >> caching

Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10 [v2]

2022-03-11 Thread Weijun Wang
On Thu, 10 Mar 2022 17:55:44 GMT, Alisen Chung wrote: >> msg drop for jdk19, Mar 9, 2022 > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > moved CurrencyNames changes to jdk.localedata The security related changes look fine,

RFR: 8282929: Localized monetary symbols are not reflected in `toLocalizedPattern` return value

2022-03-11 Thread Naoto Sato
`DecimalFormat.toLocalizedPattern()` was not honoring the monetary decimal/grouping separator symbols. Fix is straightforward to use the correct symbols depending on the formatter type. - Commit messages: - 8282929: Localized monetary symbols are not reflected in `toLocalizedPatte

Re: RFR: 8282929: Localized monetary symbols are not reflected in `toLocalizedPattern` return value [v2]

2022-03-11 Thread Naoto Sato
> `DecimalFormat.toLocalizedPattern()` was not honoring the monetary > decimal/grouping separator symbols. Fix is straightforward to use the correct > symbols depending on the formatter type. Naoto Sato has updated the pull request incrementally with one additional commit since the last revisio

Re: RFR: 8282929: Localized monetary symbols are not reflected in `toLocalizedPattern` return value [v2]

2022-03-11 Thread Joe Wang
On Fri, 11 Mar 2022 22:20:38 GMT, Naoto Sato wrote: >> `DecimalFormat.toLocalizedPattern()` was not honoring the monetary >> decimal/grouping separator symbols. Fix is straightforward to use the >> correct symbols depending on the formatter type. > > Naoto Sato has updated the pull request incr