Parameter `ChronoField field` is checked by `if (field instanceof
ChronoField)`. Such check is confusing, because only one case, when this could
be `false` is when `field == null`.
But if condition is not satisfied we will get immediate NullPointerException
anyway in `return field.range();`.
--
On Mon, 17 Jan 2022 21:02:35 GMT, Andrey Turbanov wrote:
> Parameter `ChronoField field` is checked by `if (field instanceof
> ChronoField)`. Such check is confusing, because only one case, when this
> could be `false` is when `field == null`.
> But if condition is not satisfied we will get imm
On Mon, 17 Jan 2022 21:02:35 GMT, Andrey Turbanov wrote:
> Parameter `ChronoField field` is checked by `if (field instanceof
> ChronoField)`. Such check is confusing, because only one case, when this
> could be `false` is when `field == null`.
> But if condition is not satisfied we will get imm
On Mon, 17 Jan 2022 21:02:35 GMT, Andrey Turbanov wrote:
> Parameter `ChronoField field` is checked by `if (field instanceof
> ChronoField)`. Such check is confusing, because only one case, when this
> could be `false` is when `field == null`.
> But if condition is not satisfied we will get imm
On Mon, 17 Jan 2022 21:02:35 GMT, Andrey Turbanov wrote:
> Parameter `ChronoField field` is checked by `if (field instanceof
> ChronoField)`. Such check is confusing, because only one case, when this
> could be `false` is when `field == null`.
> But if condition is not satisfied we will get imm
Reported by clang-tidy. Verified manually by running
Calendar c = Calendar.getInstance();
System.out.println (c.getDisplayNames(Calendar.MONTH,
Calendar.SHORT_STANDALONE, Locale.getDefault()));
with `-Djava.locale.providers=HOST`
Without the fix the WINAPI functions fail, and [t
On Fri, 21 Jan 2022 19:28:21 GMT, Daniel Jeliński wrote:
> Reported by clang-tidy. Verified manually by running
>
> Calendar c = Calendar.getInstance();
> System.out.println (c.getDisplayNames(Calendar.MONTH,
> Calendar.SHORT_STANDALONE, Locale.getDefault()));
>
> with `-Djava.
Thanks, Joe.
Good point. I will elaborate the pattern template part more, less
depending on the LDML spec. Would have been better if we could introduce
our own, such as ofLocalizedPattern(Set template), but not
exactly suffices the need.
Naoto
On 1/20/22 9:52 PM, Joe Wang wrote:
Hi Naoto
