Re: RFR: 8277868: Use Comparable.compare() instead of surrogate code [v2]

2021-12-06 Thread Phil Race
On Mon, 29 Nov 2021 08:18:47 GMT, Сергей Цыпанов wrote: >> Instead of something like >> >> long x; >> long y; >> return (x < y) ? -1 : ((x == y) ? 0 : 1); >> >> we can use `return Long.compare(x, y);` >> >> All replacements are done with IDE. > > Сергей Цыпанов has updated the pull request inc

Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal [v3]

2021-12-06 Thread Phil Race
On Wed, 1 Dec 2021 19:23:59 GMT, Brent Christian wrote: >> Here are the code changes for the "Deprecate finalizers in the standard Java >> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code >> review. >> >> This change makes the indicated deprecations, and updates the API

Re: RFR: 8275721: Name of UTC timezone in a locale changes depending on previous code [v3]

2021-12-06 Thread Joe Wang
On Sat, 4 Dec 2021 22:34:50 GMT, Naoto Sato wrote: >> Fixing time zone name provider for CLDR. In some cases, COMPAT's `UTC` >> display names were incorrectly substituted for CLDR. The reason it worked >> fine after `zh-Hant-HK` was that by loading names for `zh-Hant-HK`, the >> names for `zh-

Re: RFR: 8275721: Name of UTC timezone in a locale changes depending on previous code [v4]

2021-12-06 Thread Naoto Sato
> Fixing time zone name provider for CLDR. In some cases, COMPAT's `UTC` > display names were incorrectly substituted for CLDR. The reason it worked > fine after `zh-Hant-HK` was that by loading names for `zh-Hant-HK`, the names > for `zh-Hant` were cached and hit for the following `zh-MO` name

Re: RFR: 8275721: Name of UTC timezone in a locale changes depending on previous code [v3]

2021-12-06 Thread Naoto Sato
On Mon, 6 Dec 2021 18:52:51 GMT, Joe Wang wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use isFixedOffset() instead of useDaylightTime() > > src/java.base/share/classes/sun/util/cldr/CLDRTimeZoneNameProviderImpl.ja

Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal [v4]

2021-12-06 Thread Brent Christian
> Here are the code changes for the "Deprecate finalizers in the standard Java > API" portion of JEP 421 ("Deprecate Finalization for Removal") for code > review. > > This change makes the indicated deprecations, and updates the API spec for > JEP 421. It also updates the relevant @SuppressWarn

Re: RFR: 8275721: Name of UTC timezone in a locale changes depending on previous code [v4]

2021-12-06 Thread Joe Wang
On Mon, 6 Dec 2021 20:32:55 GMT, Naoto Sato wrote: >> Fixing time zone name provider for CLDR. In some cases, COMPAT's `UTC` >> display names were incorrectly substituted for CLDR. The reason it worked >> fine after `zh-Hant-HK` was that by loading names for `zh-Hant-HK`, the >> names for `zh-