RFR: 8275863: Use encodeASCII for ASCII-compatible DoubleByte encodings

2021-10-25 Thread Claes Redestad
Enhance ASCII-compatible `DoubleByte` encodings to make use of the `StringCoding.implEncodeAsciiArray` intrinsic, which makes many such `CharsetEncoder`s encode ASCII text at speeds comparable to most single-byte encoders - and also more in line with how well these charsets behave when calling

Re: RFR: 8274544: Langtools command's usage were garbled on Japanese Windows [v4]

2021-10-25 Thread Ichiroh Takiguchi
> JEP-400 (UTF-8 by Default) was eabled on JDK18-b13. > After JDK18-b13, javac and some other langtool command's usage were garbled > on Japanese Windows. > These commands use PrintWriter instead of standard out/err with PrintStream. Ichiroh Takiguchi has updated the pull request with a new targe

Re: RFR: 8274544: Langtools command's usage were garbled on Japanese Windows [v4]

2021-10-25 Thread Ichiroh Takiguchi
On Mon, 25 Oct 2021 14:20:52 GMT, Ichiroh Takiguchi wrote: >> JEP-400 (UTF-8 by Default) was eabled on JDK18-b13. >> After JDK18-b13, javac and some other langtool command's usage were garbled >> on Japanese Windows. >> These commands use PrintWriter instead of standard out/err with PrintStream

RFR: 8275767: JDK source code contains redundant boolean operations in jdk.charsets

2021-10-25 Thread Naoto Sato
Trivial clean-up. - Commit messages: - 8275767: JDK source code contains redundant boolean operations in jdk.charsets Changes: https://git.openjdk.java.net/jdk/pull/6110/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6110&range=00 Issue: https://bugs.openjdk.java.ne

Re: RFR: 8275767: JDK source code contains redundant boolean operations in jdk.charsets

2021-10-25 Thread Lance Andersen
On Mon, 25 Oct 2021 16:08:29 GMT, Naoto Sato wrote: > Trivial clean-up. Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6110

Re: RFR: 8275767: JDK source code contains redundant boolean operations in jdk.charsets

2021-10-25 Thread Roger Riggs
On Mon, 25 Oct 2021 16:08:29 GMT, Naoto Sato wrote: > Trivial clean-up. Given that the code has been that way for a *long time*, did you check that both paths work as intended and that tests exist for both paths? - PR: https://git.openjdk.java.net/jdk/pull/6110

Re: RFR: 8275767: JDK source code contains redundant boolean operations in jdk.charsets

2021-10-25 Thread Naoto Sato
On Mon, 25 Oct 2021 16:08:29 GMT, Naoto Sato wrote: > Trivial clean-up. No, I did not check. I simply removed the `true &&` as it is logically correct. There's a test specifying `IBM964` in `sun.nio.cs.TestIBMBugs.java`, but not sure it tests both paths or not. - PR: https://git.

Re: RFR: 8275767: JDK source code contains redundant boolean operations in jdk.charsets

2021-10-25 Thread Roger Riggs
On Mon, 25 Oct 2021 16:08:29 GMT, Naoto Sato wrote: > Trivial clean-up. LGTM - Marked as reviewed by rriggs (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6110

Re: RFR: 8275767: JDK source code contains redundant boolean operations in jdk.charsets

2021-10-25 Thread Iris Clark
On Mon, 25 Oct 2021 16:08:29 GMT, Naoto Sato wrote: > Trivial clean-up. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6110