Re: RFR: 8275197: Remove unused fields in ThaiBuddhistChronology

2021-10-14 Thread Roger Riggs
On Tue, 12 Oct 2021 21:10:12 GMT, Andrey Turbanov wrote: > Remove 3 unused HashMap's. > Reported here > https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-September/081866.html > I did the similar PR to treetenbp and it was merged > https://github.com/ThreeTen/threetenbp/pull/155 Marke

Re: RFR: 8275197: Remove unused fields in ThaiBuddhistChronology

2021-10-14 Thread Iris Clark
On Tue, 12 Oct 2021 21:10:12 GMT, Andrey Turbanov wrote: > Remove 3 unused HashMap's. > Reported here > https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-September/081866.html > I did the similar PR to treetenbp and it was merged > https://github.com/ThreeTen/threetenbp/pull/155 Marke

Re: RFR: 8274544: Langtools command's usage were garbled on Japanese Windows

2021-10-14 Thread Naoto Sato
On Mon, 4 Oct 2021 10:24:01 GMT, Jan Lahoda wrote: >> Helllo @naotoj . >> I used `System.console()` and `Console.charset()`. >> >> The following executables had same issue, I fixed them. >>> jar.exe, javac.exe, javadoc.exe, javap.exe, jdeps.exe, jlink.exe, jmod.exe, >>> jpackage.exe >> >> I co

Re: RFR: 8275106: Cleanup Iterator usages in java.desktop

2021-10-14 Thread Pankaj Bansal
On Fri, 8 Oct 2021 19:37:35 GMT, Andrey Turbanov wrote: > Cycles with 'Iterator' are error-prone. It's better to use more high-level > code, which easier to read. > We can use enhanced-for or Collection.removeIf Marked as reviewed by pbansal (Reviewer). - PR: https://git.openjdk.j