On Thu, 7 Oct 2021 21:30:22 GMT, Naoto Sato wrote:
> While working on tzdata2021c update, I noticed there is a dead code in
> `sun.util.calendar.ZoneInfoFile`, which was used to tweak the rules for
> `endOfDay` for certain cases. These are no longer needed as JDK's code is
> already capable of
String.contains was introduced in Java 5.
Some code in java.base still uses old approach with `String.indexOf` to check
if String contains specified substring.
I propose to migrate such usages. Makes code shorter and easier to read.
-
Commit messages:
- [PATCH] Use String.contains()
On Fri, 17 Sep 2021 08:56:47 GMT, Andrey Turbanov
wrote:
> String.contains was introduced in Java 5.
> Some code in java.base still uses old approach with `String.indexOf` to check
> if String contains specified substring.
> I propose to migrate such usages. Makes code shorter and easier to rea
On Sat, 25 Sep 2021 19:30:31 GMT, Сергей Цыпанов
wrote:
>> This is a continuation of
>>
>> - https://bugs.openjdk.java.net/browse/JDK-6736490
>> - https://bugs.openjdk.java.net/browse/JDK-8035284
>> - https://bugs.openjdk.java.net/browse/JDK-8145680
>> - https://bugs.openjdk.java.net/browse/JDK
On Fri, 17 Sep 2021 08:56:47 GMT, Andrey Turbanov
wrote:
> String.contains was introduced in Java 5.
> Some code in java.base still uses old approach with `String.indexOf` to check
> if String contains specified substring.
> I propose to migrate such usages. Makes code shorter and easier to rea
On Fri, 17 Sep 2021 08:56:47 GMT, Andrey Turbanov
wrote:
> String.contains was introduced in Java 5.
> Some code in java.base still uses old approach with `String.indexOf` to check
> if String contains specified substring.
> I propose to migrate such usages. Makes code shorter and easier to rea
On Fri, 17 Sep 2021 08:56:47 GMT, Andrey Turbanov
wrote:
> String.contains was introduced in Java 5.
> Some code in java.base still uses old approach with `String.indexOf` to check
> if String contains specified substring.
> I propose to migrate such usages. Makes code shorter and easier to rea
On Fri, 8 Oct 2021 09:35:25 GMT, Daniel Fuchs wrote:
>Did you run tier1, tier2?
I did run tier2. (tier1 is automatically checked by GithubActions).
No new tests failed. Only _usual_ tests, which always fail on my machine, were
failed.
-
PR: https://git.openjdk.java.net/jdk/pull/55
On Sat, 25 Sep 2021 19:30:31 GMT, Сергей Цыпанов
wrote:
>> This is a continuation of
>>
>> - https://bugs.openjdk.java.net/browse/JDK-6736490
>> - https://bugs.openjdk.java.net/browse/JDK-8035284
>> - https://bugs.openjdk.java.net/browse/JDK-8145680
>> - https://bugs.openjdk.java.net/browse/JDK
On Fri, 20 Aug 2021 09:41:15 GMT, Сергей Цыпанов
wrote:
> This is a continuation of
>
> - https://bugs.openjdk.java.net/browse/JDK-6736490
> - https://bugs.openjdk.java.net/browse/JDK-8035284
> - https://bugs.openjdk.java.net/browse/JDK-8145680
> - https://bugs.openjdk.java.net/browse/JDK-82515
On Thu, 7 Oct 2021 21:30:22 GMT, Naoto Sato wrote:
> While working on tzdata2021c update, I noticed there is a dead code in
> `sun.util.calendar.ZoneInfoFile`, which was used to tweak the rules for
> `endOfDay` for certain cases. These are no longer needed as JDK's code is
> already capable of
On Wed, 6 Oct 2021 18:08:04 GMT, Naoto Sato wrote:
>> Ichiroh Takiguchi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8274544: Langtools command's usage were garbled on Japanese Windows
>
> I got your issue now. Since the current code
On Wed, 6 Oct 2021 18:08:04 GMT, Naoto Sato wrote:
>> Ichiroh Takiguchi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8274544: Langtools command's usage were garbled on Japanese Windows
>
> I got your issue now. Since the current code
On Sun, 26 Sep 2021 20:57:58 GMT, Sergey Bylokhov wrote:
>> Agree.
>
> I still suggest to remove the local tag completely.
@jayathirthrao @stsypanov Looks like this was not addressed? It will be good
to include it in some future cleanup.
-
PR: https://git.openjdk.java.net/jdk/pu
On Fri, 8 Oct 2021 18:35:53 GMT, Sergey Bylokhov wrote:
>> I still suggest to remove the local tag completely.
>
> @jayathirthrao @stsypanov Looks like this was not addressed? It will be
> good to include it in some future cleanup.
As far as I can see, it was. [Line
64](https://github.com/st
On Fri, 8 Oct 2021 18:44:41 GMT, Alexey Ivanov wrote:
>> @jayathirthrao @stsypanov Looks like this was not addressed? It will be
>> good to include it in some future cleanup.
>
> As far as I can see, it was. [Line
> 64](https://github.com/stsypanov/jdk/blob/d13ca9004b8e45f7df57c849271f3cfda5c
On Fri, 8 Oct 2021 19:15:39 GMT, Sergey Bylokhov wrote:
>> As far as I can see, it was. [Line
>> 64](https://github.com/stsypanov/jdk/blob/d13ca9004b8e45f7df57c849271f3cfda5c43ec9/src/java.desktop/share/classes/com/sun/imageio/plugins/tiff/TIFFIFD.java#L64):
>>
>> essentialTags = Se
On Wed, 6 Oct 2021 05:04:28 GMT, Ichiroh Takiguchi
wrote:
>> JEP-400 (UTF-8 by Default) was eabled on JDK18-b13.
>> After JDK18-b13, javac and some other langtool command's usage were garbled
>> on Japanese Windows.
>> These commands use PrintWriter instead of standard out/err with PrintStream.
On Sat, 2 Oct 2021 09:14:49 GMT, Andrey Turbanov
wrote:
> Flipping arguments of 'equals' method, allows simplifying boolean
> expressions: now we can remove redundant null check before.
This pull request has now been integrated.
Changeset: f640c7aa
Author:Andrey Turbanov
Committer: Serge
19 matches
Mail list logo
