RFR: 8274640: Cleanup unnecessary null comparison before instanceof check in java.desktop

2021-10-01 Thread Andrey Turbanov
Updated code checks both non-null and instance of a class in java.desktop module classes. The checks and explicit casts could also be replaced with pattern matching for the instanceof operator. Similar cleanups 1. [JDK-8273484](https://bugs.openjdk.java.net/browse/JDK-8273484) java.naming 2. [JD

Re: RFR: 8274544: Langtools command's usage were grabled on Japanese Windows

2021-10-01 Thread Jan Lahoda
On Thu, 30 Sep 2021 09:36:34 GMT, Ichiroh Takiguchi wrote: > JEP-400 (UTF-8 by Default) was eabled on JDK18-b13. > After JDK18-b13, javac and some other langtool command's usage were garbled > on Japanese Windows. > These commands use PrintWriter instead of standard out/err with PrintStream. R

Re: RFR: 8274544: Langtools command's usage were grabled on Japanese Windows

2021-10-01 Thread Pavel Rappo
On Thu, 30 Sep 2021 09:36:34 GMT, Ichiroh Takiguchi wrote: > JEP-400 (UTF-8 by Default) was eabled on JDK18-b13. > After JDK18-b13, javac and some other langtool command's usage were garbled > on Japanese Windows. > These commands use PrintWriter instead of standard out/err with PrintStream. F

Re: RFR: 8274544: Langtools command's usage were garbled on Japanese Windows

2021-10-01 Thread Jan Lahoda
On Fri, 1 Oct 2021 11:56:03 GMT, Jan Lahoda wrote: > Regarding javac, the patch to `Log.java` seems to be in a reasonable > direction: the write is to the physical `System.out/err` which should be > done(?) using the native encoding. The order of the changed lines should be > fixed, so that th

Re: RFR: 8274544: Langtools command's usage were garbled on Japanese Windows

2021-10-01 Thread Ichiroh Takiguchi
On Fri, 1 Oct 2021 12:13:03 GMT, Pavel Rappo wrote: >> JEP-400 (UTF-8 by Default) was eabled on JDK18-b13. >> After JDK18-b13, javac and some other langtool command's usage were garbled >> on Japanese Windows. >> These commands use PrintWriter instead of standard out/err with PrintStream. > > Fo

Re: RFR: 8274544: Langtools command's usage were garbled on Japanese Windows

2021-10-01 Thread Naoto Sato
On Thu, 30 Sep 2021 09:36:34 GMT, Ichiroh Takiguchi wrote: > JEP-400 (UTF-8 by Default) was eabled on JDK18-b13. > After JDK18-b13, javac and some other langtool command's usage were garbled > on Japanese Windows. > These commands use PrintWriter instead of standard out/err with PrintStream. T

RFR: 8274658: ISO 4217 Amendment #170 Update

2021-10-01 Thread Naoto Sato
This is to incorporate the ISO 4217 amendment #170, which has been released today, effective immediately. - Commit messages: - 8274658: ISO 4217 Amendment #170 Update Changes: https://git.openjdk.java.net/jdk/pull/5790/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=57

Re: RFR: 8274658: ISO 4217 Amendment #170 Update

2021-10-01 Thread Lance Andersen
On Fri, 1 Oct 2021 18:57:28 GMT, Naoto Sato wrote: > This is to incorporate the ISO 4217 amendment #170, which has been released > today, effective immediately. Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5790

Re: RFR: 8274658: ISO 4217 Amendment 170 Update

2021-10-01 Thread Iris Clark
On Fri, 1 Oct 2021 18:57:28 GMT, Naoto Sato wrote: > This is to incorporate the ISO 4217 amendment #170, which has been released > today, effective immediately. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5790