RFR: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields

2021-09-27 Thread Joe Darcy
This is an initial PR for expanded lint warnings done under two bugs: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields 8160675: Issue lint warning for non-serializable non-transient instance fields in serializable type to get feedback on

Re: RFR: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields

2021-09-27 Thread Erik Joelsson
On Mon, 27 Sep 2021 01:00:18 GMT, Joe Darcy wrote: > This is an initial PR for expanded lint warnings done under two bugs: > > 8202056: Expand serial warning to check for bad overloads of serial-related > methods and ineffectual fields > 8160675: Issue lint warning for non-serializable non-tran

Re: RFR: 8273790: Potential cyclic dependencies between Gregorian and CalendarSystem [v2]

2021-09-27 Thread Naoto Sato
On Sat, 25 Sep 2021 03:38:24 GMT, Jaikiran Pai wrote: >> Can I please get a review for this change which proposes to fix the issue >> reported in https://bugs.openjdk.java.net/browse/JDK-8273790? >> >> As noted in that issue, trying to class load >> `sun.util.calendar.CalendarSystem` and `sun.

Re: RFR: 8273790: Potential cyclic dependencies between Gregorian and CalendarSystem [v2]

2021-09-27 Thread Roger Riggs
On Sat, 25 Sep 2021 03:38:24 GMT, Jaikiran Pai wrote: >> Can I please get a review for this change which proposes to fix the issue >> reported in https://bugs.openjdk.java.net/browse/JDK-8273790? >> >> As noted in that issue, trying to class load >> `sun.util.calendar.CalendarSystem` and `sun.

RFR: 8274396: Suppress more warnings on non-serializable non-transient intance fields in client libs

2021-09-27 Thread Joe Darcy
Follow-up changes to JDK-8231334. , augmentations to javac's Xlint:serial checking are out for review (#5709) and various client libraries would need some changes to pass under the expanded checks. The changes are to suppress warnings where non-transient fields in serializable types are not dec

Re: RFR: 8274396: Suppress more warnings on non-serializable non-transient intance fields in client libs

2021-09-27 Thread Brian Burkhalter
On Mon, 27 Sep 2021 20:21:43 GMT, Joe Darcy wrote: > Follow-up changes to JDK-8231334. , augmentations to javac's Xlint:serial > checking are out for review (#5709) and various client libraries would need > some changes to pass under the expanded checks. > > The changes are to suppress warning

Re: RFR: 8274396: Suppress more warnings on non-serializable non-transient intance fields in client libs

2021-09-27 Thread Naoto Sato
On Mon, 27 Sep 2021 20:21:43 GMT, Joe Darcy wrote: > Follow-up changes to JDK-8231334. , augmentations to javac's Xlint:serial > checking are out for review (#5709) and various client libraries would need > some changes to pass under the expanded checks. > > The changes are to suppress warning

Re: RFR: 8274396: Suppress more warnings on non-serializable non-transient intance fields in client libs

2021-09-27 Thread Sergey Bylokhov
On Mon, 27 Sep 2021 20:21:43 GMT, Joe Darcy wrote: > Follow-up changes to JDK-8231334. , augmentations to javac's Xlint:serial > checking are out for review (#5709) and various client libraries would need > some changes to pass under the expanded checks. > > The changes are to suppress warning

Re: RFR: 8274396: Suppress more warnings on non-serializable non-transient intance fields in client libs [v2]

2021-09-27 Thread Joe Darcy
> Follow-up changes to JDK-8231334. , augmentations to javac's Xlint:serial > checking are out for review (#5709) and various client libraries would need > some changes to pass under the expanded checks. > > The changes are to suppress warnings where non-transient fields in > serializable types

Re: RFR: 8274396: Suppress more warnings on non-serializable non-transient intance fields in client libs

2021-09-27 Thread Joe Darcy
On Mon, 27 Sep 2021 21:40:13 GMT, Sergey Bylokhov wrote: > > > Can we add comments to SuppressWarnings on why it was added? Previously we > use this text > > > // Not statically typed as Serializable Added in revision; used a different comment wording. - PR: https://git.openjdk

Re: RFR: 8274396: Suppress more warnings on non-serializable non-transient intance fields in client libs [v2]

2021-09-27 Thread Sergey Bylokhov
On Mon, 27 Sep 2021 22:48:24 GMT, Joe Darcy wrote: >> Follow-up changes to JDK-8231334. , augmentations to javac's Xlint:serial >> checking are out for review (#5709) and various client libraries would need >> some changes to pass under the expanded checks. >> >> The changes are to suppress wa

Integrated: 8273790: Potential cyclic dependencies between Gregorian and CalendarSystem

2021-09-27 Thread Jaikiran Pai
On Fri, 24 Sep 2021 14:36:07 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which proposes to fix the issue > reported in https://bugs.openjdk.java.net/browse/JDK-8273790? > > As noted in that issue, trying to class load > `sun.util.calendar.CalendarSystem` and `sun.util.

Re: RFR: 8273790: Potential cyclic dependencies between Gregorian and CalendarSystem [v2]

2021-09-27 Thread Jaikiran Pai
On Sat, 25 Sep 2021 03:38:24 GMT, Jaikiran Pai wrote: >> Can I please get a review for this change which proposes to fix the issue >> reported in https://bugs.openjdk.java.net/browse/JDK-8273790? >> >> As noted in that issue, trying to class load >> `sun.util.calendar.CalendarSystem` and `sun.