Re: [jdk17] RFR: 8269409: Post JEP 411 refactoring: core-libs with maximum covering > 10K [v2]

2021-06-28 Thread Daniel Fuchs
On Sat, 26 Jun 2021 23:55:46 GMT, Weijun Wang wrote: >> src/jdk.attach/share/classes/sun/tools/attach/HotSpotVirtualMachine.java >> line 53: >> >>> 51: private static final long CURRENT_PID = >>> AccessController.doPrivileged( >>> 52: (PrivilegedAction) >>> ProcessHandle::curr

Re: [jdk17] RFR: 8269409: Post JEP 411 refactoring: core-libs with maximum covering > 10K [v3]

2021-06-28 Thread Weijun Wang
> More refactoring to limit the scope of `@SuppressWarnings` annotations. > > Sometimes I introduce new methods. Please feel free to suggest method names > you like to use. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: one more ref

Re: [jdk17] RFR: 8269409: Post JEP 411 refactoring: core-libs with maximum covering > 10K [v2]

2021-06-28 Thread Weijun Wang
On Fri, 25 Jun 2021 23:40:27 GMT, Weijun Wang wrote: >> More refactoring to limit the scope of `@SuppressWarnings` annotations. >> >> Sometimes I introduce new methods. Please feel free to suggest method names >> you like to use. > > Weijun Wang has updated the pull request incrementally with o

Re: [jdk17] RFR: 8269409: Post JEP 411 refactoring: core-libs with maximum covering > 10K [v2]

2021-06-28 Thread Weijun Wang
On Mon, 28 Jun 2021 12:20:38 GMT, Daniel Fuchs wrote: >> This cast is only to tell the compiler which overloaded method to call, and >> I don't think there will be a real cast at runtime. It might look a little >> ugly but extracting it into a variable declaration/definition plus a new >> `ini

[jdk17] RFR: 8269513: Clarify the spec wrt `useOldISOCodes` system property

2021-06-28 Thread Naoto Sato
Please review this small doc change to the system property. Accompanying CSR has also been created. - Commit messages: - 8269513: Clarify the spec wrt `useOldISOCodes` system property Changes: https://git.openjdk.java.net/jdk17/pull/163/files Webrev: https://webrevs.openjdk.java.n

Re: [jdk17] RFR: 8269513: Clarify the spec wrt `useOldISOCodes` system property

2021-06-28 Thread Lance Andersen
On Mon, 28 Jun 2021 16:57:15 GMT, Naoto Sato wrote: > Please review this small doc change to the system property. Accompanying CSR > has also been created. Looks good Naoto - Marked as reviewed by lancea (Reviewer). PR: https://git.openjdk.java.net/jdk17/pull/163

[jdk17] Withdrawn: 8269409: Post JEP 411 refactoring: core-libs with maximum covering > 10K

2021-06-28 Thread Weijun Wang
On Fri, 25 Jun 2021 20:04:37 GMT, Weijun Wang wrote: > More refactoring to limit the scope of `@SuppressWarnings` annotations. > > Sometimes I introduce new methods. Please feel free to suggest method names > you like to use. This pull request has been closed without being integrated. ---

RFR: 8269409: Post JEP 411 refactoring: core-libs with maximum covering > 10K

2021-06-28 Thread Weijun Wang
More refactoring to limit the scope of `@SuppressWarnings` annotations. Sometimes I introduce new methods. Please feel free to suggest method names you like to use. Note: this is copied from https://github.com/openjdk/jdk17/pull/152. - Commit messages: - copy all code change from

Re: [jdk17] RFR: 8269513: Clarify the spec wrt `useOldISOCodes` system property [v2]

2021-06-28 Thread Naoto Sato
> Please review this small doc change to the system property. Accompanying CSR > has also been created. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Refined wording. - Changes: - all: https://git.openjdk.java.net/jdk

Re: RFR: 8269409: Post JEP 411 refactoring: core-libs with maximum covering > 10K

2021-06-28 Thread Lance Andersen
On Mon, 28 Jun 2021 18:03:56 GMT, Weijun Wang wrote: > More refactoring to limit the scope of `@SuppressWarnings` annotations. > > Sometimes I introduce new methods. Please feel free to suggest method names > you like to use. > > Note: this is copied from https://github.com/openjdk/jdk17/pull/

Re: [jdk17] RFR: 8269513: Clarify the spec wrt `useOldISOCodes` system property [v2]

2021-06-28 Thread Brian Burkhalter
On Mon, 28 Jun 2021 18:37:34 GMT, Naoto Sato wrote: >> Please review this small doc change to the system property. Accompanying CSR >> has also been created. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Refined wording.

Re: [jdk17] RFR: 8269513: Clarify the spec wrt `useOldISOCodes` system property [v2]

2021-06-28 Thread Lance Andersen
On Mon, 28 Jun 2021 18:37:34 GMT, Naoto Sato wrote: >> Please review this small doc change to the system property. Accompanying CSR >> has also been created. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Refined wording.

Integrated: 8269409: Post JEP 411 refactoring: core-libs with maximum covering > 10K

2021-06-28 Thread Weijun Wang
On Mon, 28 Jun 2021 18:03:56 GMT, Weijun Wang wrote: > More refactoring to limit the scope of `@SuppressWarnings` annotations. > > Sometimes I introduce new methods. Please feel free to suggest method names > you like to use. > > Note: this is copied from https://github.com/openjdk/jdk17/pull/

Re: [jdk17] RFR: 8269513: Clarify the spec wrt `useOldISOCodes` system property [v2]

2021-06-28 Thread Iris Clark
On Mon, 28 Jun 2021 18:37:34 GMT, Naoto Sato wrote: >> Please review this small doc change to the system property. Accompanying CSR >> has also been created. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Refined wording.

Re: [jdk17] RFR: 8269513: Clarify the spec wrt `useOldISOCodes` system property [v2]

2021-06-28 Thread Joe Wang
On Mon, 28 Jun 2021 18:37:34 GMT, Naoto Sato wrote: >> Please review this small doc change to the system property. Accompanying CSR >> has also been created. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Refined wording.

Re: [jdk17] RFR: 8269513: Clarify the spec wrt `useOldISOCodes` system property [v2]

2021-06-28 Thread Joe Wang
On Mon, 28 Jun 2021 18:45:31 GMT, Lance Andersen wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Refined wording. > > src/java.base/share/classes/java/util/Locale.java line 460: > >> 458: * back to that of before J

Re: [jdk17] RFR: 8269513: Clarify the spec wrt `useOldISOCodes` system property [v3]

2021-06-28 Thread Naoto Sato
> Please review this small doc change to the system property. Accompanying CSR > has also been created. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Refined wording #2. - Changes: - all: https://git.openjdk.java.net/

Re: [jdk17] RFR: 8269513: Clarify the spec wrt `useOldISOCodes` system property [v2]

2021-06-28 Thread Naoto Sato
On Mon, 28 Jun 2021 18:37:34 GMT, Naoto Sato wrote: >> Please review this small doc change to the system property. Accompanying CSR >> has also been created. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Refined wording.

Re: [jdk17] RFR: 8269513: Clarify the spec wrt `useOldISOCodes` system property [v4]

2021-06-28 Thread Naoto Sato
> Please review this small doc change to the system property. Accompanying CSR > has also been created. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Missed one. - Changes: - all: https://git.openjdk.java.net/jdk17/pu

Re: [jdk17] RFR: 8269513: Clarify the spec wrt `useOldISOCodes` system property [v4]

2021-06-28 Thread Iris Clark
On Mon, 28 Jun 2021 20:33:29 GMT, Naoto Sato wrote: >> Please review this small doc change to the system property. Accompanying CSR >> has also been created. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Missed one. Marke

Re: [jdk17] RFR: 8269513: Clarify the spec wrt `useOldISOCodes` system property [v4]

2021-06-28 Thread Lance Andersen
On Mon, 28 Jun 2021 20:33:29 GMT, Naoto Sato wrote: >> Please review this small doc change to the system property. Accompanying CSR >> has also been created. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Missed one. Marke

Re: [jdk17] RFR: 8269513: Clarify the spec wrt `useOldISOCodes` system property [v4]

2021-06-28 Thread Joe Wang
On Mon, 28 Jun 2021 20:33:29 GMT, Naoto Sato wrote: >> Please review this small doc change to the system property. Accompanying CSR >> has also been created. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Missed one. Marke