Re: RFR: 8266155: Convert java.base to use Stream.toList()

2021-04-28 Thread Chris Hegarty
On Tue, 27 Apr 2021 21:34:02 GMT, Ian Graves wrote: > 8266155: Convert java.base to use Stream.toList() Marked as reviewed by chegar (Reviewer). src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 6788: > 6786: } > 6787: > 6788: /** I think the import of Collectors c

RFR: 8264678: Incomplete comment in build.tools.generatecharacter.GenerateCharacter

2021-04-28 Thread Claes Redestad
I'm not exactly sure what I intended to say in this partial comment. Removing it. - Commit messages: - Incomplete comment in build.tools.generatecharacter.GenerateCharacter Changes: https://git.openjdk.java.net/jdk/pull/3766/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk

Re: RFR: 8264678: Incomplete comment in build.tools.generatecharacter.GenerateCharacter

2021-04-28 Thread Erik Joelsson
On Wed, 28 Apr 2021 15:44:47 GMT, Claes Redestad wrote: > I'm not exactly sure what I intended to say in this partial comment. Removing > it. Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3766

Re: RFR: 8266155: Convert java.base to use Stream.toList()

2021-04-28 Thread Alan Bateman
On Wed, 28 Apr 2021 15:41:31 GMT, Chris Hegarty wrote: >> 8266155: Convert java.base to use Stream.toList() > > src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 6788: > >> 6786: } >> 6787: >> 6788: /** > > I think the import of Collectors can be dropped in this file

Re: RFR: 8264678: Incomplete comment in build.tools.generatecharacter.GenerateCharacter

2021-04-28 Thread Naoto Sato
On Wed, 28 Apr 2021 15:44:47 GMT, Claes Redestad wrote: > I'm not exactly sure what I intended to say in this partial comment. Removing > it. Marked as reviewed by naoto (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3766

Re: RFR: 8264678: Incomplete comment in build.tools.generatecharacter.GenerateCharacter

2021-04-28 Thread Iris Clark
On Wed, 28 Apr 2021 15:44:47 GMT, Claes Redestad wrote: > I'm not exactly sure what I intended to say in this partial comment. Removing > it. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3766

Re: RFR: 8266155: Convert java.base to use Stream.toList() [v2]

2021-04-28 Thread Ian Graves
> 8266155: Convert java.base to use Stream.toList() Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Removing redundant imports - Changes: - all: https://git.openjdk.java.net/jdk/pull/3734/files - new: https://git.openj

Re: RFR: 8266155: Convert java.base to use Stream.toList() [v2]

2021-04-28 Thread Iris Clark
On Wed, 28 Apr 2021 16:57:25 GMT, Ian Graves wrote: >> 8266155: Convert java.base to use Stream.toList() > > Ian Graves has updated the pull request incrementally with one additional > commit since the last revision: > > Removing redundant imports Marked as reviewed by iris (Reviewer).

Re: RFR: 8266155: Convert java.base to use Stream.toList() [v2]

2021-04-28 Thread Chris Hegarty
On Wed, 28 Apr 2021 16:57:25 GMT, Ian Graves wrote: >> 8266155: Convert java.base to use Stream.toList() > > Ian Graves has updated the pull request incrementally with one additional > commit since the last revision: > > Removing redundant imports Marked as reviewed by chegar (Reviewer). --

Integrated: 8264678: Incomplete comment in build.tools.generatecharacter.GenerateCharacter

2021-04-28 Thread Claes Redestad
On Wed, 28 Apr 2021 15:44:47 GMT, Claes Redestad wrote: > I'm not exactly sure what I intended to say in this partial comment. Removing > it. This pull request has now been integrated. Changeset: 9df6cc7c Author:Claes Redestad URL: https://git.openjdk.java.net/jdk/commit/9df6cc7cc2