On Wed, 14 Apr 2021 21:13:51 GMT, Naoto Sato wrote:
> Please review the changes to support CLDR version 39. The vast majority of
> the changes are purely data changes from Unicode. The only change affected in
> logic was in `CLDRLocaleProviderAdapter.java`, where it needed to deal with
> CLDR'
On Thu, 15 Apr 2021 03:57:18 GMT, Naoto Sato wrote:
>> Jaikiran Pai has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - update existing testcase based on review comment
>> - Improve code comment to be clear it's only applicable for
>>
On Fri, 16 Apr 2021 02:35:23 GMT, Jaikiran Pai wrote:
>> test/jdk/java/util/Calendar/NarrowNamesTest.java line 115:
>>
>>> 113: } else {
>>> 114: testMap(US, AM_PM, ALL_STYLES,
>>> 115: "AM", "PM",
>>
>> What I meant was there is no need to check the prov
On Fri, 16 Apr 2021 03:51:22 GMT, Naoto Sato wrote:
>> Hello Naoto,
>>
>> As far as I can see, the testMap cannot be used to test the day period
>> strings. More specifically, consider this change (git diff) that I did as
>> you suggested (unless I misunderstood what you meant):
>>
>>
>> +
> Can I please get a review for this proposed fix for
> https://bugs.openjdk.java.net/browse/JDK-8262108?
>
> As noted in a comment in that issue, the bug relates to the return value of
> `Calendar.getDisplayNames` for the `Calendar.AM_PM` field. The implementation
> has started returning inval
On Fri, 16 Apr 2021 04:06:54 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this proposed fix for
>> https://bugs.openjdk.java.net/browse/JDK-8262108?
>>
>> As noted in a comment in that issue, the bug relates to the return value of
>> `Calendar.getDisplayNames` for the `Calendar.AM
On Tue, 13 Apr 2021 11:42:41 GMT, Jaikiran Pai wrote:
> Can I please get a review for this proposed fix for
> https://bugs.openjdk.java.net/browse/JDK-8262108?
>
> As noted in a comment in that issue, the bug relates to the return value of
> `Calendar.getDisplayNames` for the `Calendar.AM_PM`
On Fri, 16 Apr 2021 04:06:54 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this proposed fix for
>> https://bugs.openjdk.java.net/browse/JDK-8262108?
>>
>> As noted in a comment in that issue, the bug relates to the return value of
>> `Calendar.getDisplayNames` for the `Calendar.AM
