> Please review this doc fix to j.l.Character, which now includes the table of
> the history of supported Unicode versions. A corresponding CSR will be filed
> accordingly.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Added a text
On Wed, 17 Feb 2021 17:39:00 GMT, Naoto Sato wrote:
>> Please review this doc fix to j.l.Character, which now includes the table of
>> the history of supported Unicode versions. A corresponding CSR will be filed
>> accordingly.
>
> Naoto Sato has updated the pull request incrementally with one
Please review this simple doc fix. A CSR will be filed accordingly.
-
Commit messages:
- 8261728: SimpleDateFormat should link to DateTimeFormatter
Changes: https://git.openjdk.java.net/jdk/pull/2616/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2616&range=00
Issue:
On Wed, 17 Feb 2021 19:34:47 GMT, Naoto Sato wrote:
> Please review this simple doc fix. A CSR will be filed accordingly.
LGTM
-
Marked as reviewed by bpb (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2616
On Wed, 17 Feb 2021 19:34:47 GMT, Naoto Sato wrote:
> Please review this simple doc fix. A CSR will be filed accordingly.
Hi Naoto,
Looks good.
Any thoughts to making the new wording stick out more perhaps via a something
like "Note: Consider" and bolding "Note:"
Not sure if it is @
On Wed, 17 Feb 2021 19:34:47 GMT, Naoto Sato wrote:
> Please review this simple doc fix. A CSR will be filed accordingly.
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2616
On Wed, 17 Feb 2021 20:18:56 GMT, Naoto Sato wrote:
>> Please review this simple doc fix. A CSR will be filed accordingly.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Made the additional text an @apiNote
Marked as review
> Please review this simple doc fix. A CSR will be filed accordingly.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Made the additional text an @apiNote
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2616/file
On Wed, 17 Feb 2021 20:18:56 GMT, Naoto Sato wrote:
>> Please review this simple doc fix. A CSR will be filed accordingly.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Made the additional text an @apiNote
Marked as review
On Wed, 17 Feb 2021 20:04:33 GMT, Lance Andersen wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Made the additional text an @apiNote
>
> Hi Naoto,
>
> Looks good.
>
> Any thoughts to making the new wording stick
On Fri, 12 Feb 2021 02:50:35 GMT, Naoto Sato wrote:
> Please review this doc fix to j.l.Character, which now includes the table of
> the history of supported Unicode versions. A corresponding CSR will be filed
> accordingly.
This pull request has now been integrated.
Changeset: ea5bf45c
Autho
On Wed, 17 Feb 2021 20:21:57 GMT, Naoto Sato wrote:
>> Please review this simple doc fix. A CSR will be filed accordingly.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Made the additional text an @apiNote
Marked as review
On Fri, 12 Feb 2021 15:22:15 GMT, Roger Riggs wrote:
>
>
> The table is informative and should not be construed as specification.
> The wording "has supported" should be sufficient.
If this is not specification then doesn't that imply that any provider of any
version of OpenJDK would be free
13 matches
Mail list logo
