Re: RFR: 8261418: Reduce decoder creation overheads for sun.nio.cs.ext Charsets

2021-02-09 Thread Claes Redestad
On Tue, 9 Feb 2021 12:54:12 GMT, Claes Redestad wrote: > This refactor some `sun.nio.cs.ext` charsets, such as ISO-2022-CN-GB, > ISO-2022-CN-CNS, ISO-2022-KR and a few others to use static rather than > per-instance auxiliary decoders. Doing so reduce overheads of calling > `charset.newDecoder

RFR: 8261418: Reduce decoder creation overheads for sun.nio.cs.ext Charsets

2021-02-09 Thread Claes Redestad
This refactor some `sun.nio.cs.ext` charsets, such as ISO-2022-CN-GB, ISO-2022-CN-CNS, ISO-2022-KR and a few others to use static rather than per-instance auxiliary decoders. Doing so reduce overheads of calling `charset.newDecoder()`. This reduce or eliminate regressions on `new String(byte[],

Integrated: 8261279: sun/util/resources/cldr/TimeZoneNamesTest.java timed out

2021-02-09 Thread Naoto Sato
On Mon, 8 Feb 2021 21:42:36 GMT, Naoto Sato wrote: > Please review this simple test case fix. By sampling locales to test, it > reduces the possibility of the time out. This pull request has now been integrated. Changeset: becee643 Author:Naoto Sato URL: https://git.openjdk.java.net

Re: RFR: 8261418: Reduce decoder creation overheads for sun.nio.cs.ext Charsets

2021-02-09 Thread Naoto Sato
On Tue, 9 Feb 2021 12:54:12 GMT, Claes Redestad wrote: > This refactor some `sun.nio.cs.ext` charsets, such as ISO-2022-CN-GB, > ISO-2022-CN-CNS, ISO-2022-KR and a few others to use static rather than > per-instance auxiliary decoders. Doing so reduce overheads of calling > `charset.newDecoder

Re: RFR: 8261418: Reduce decoder creation overheads for sun.nio.cs.ext Charsets

2021-02-09 Thread Claes Redestad
On Tue, 9 Feb 2021 19:14:09 GMT, Naoto Sato wrote: >> This refactor some `sun.nio.cs.ext` charsets, such as ISO-2022-CN-GB, >> ISO-2022-CN-CNS, ISO-2022-KR and a few others to use static rather than >> per-instance auxiliary decoders. Doing so reduce overheads of calling >> `charset.newDecoder

Re: RFR: 8261418: Reduce decoder creation overheads for sun.nio.cs.ext Charsets

2021-02-09 Thread Naoto Sato
On Tue, 9 Feb 2021 19:43:06 GMT, Claes Redestad wrote: >> src/jdk.charsets/share/classes/sun/nio/cs/ext/EUC_JP.java.template line 116: >> >>> 114: int sp = src.arrayOffset() + src.position(); >>> 115: int sl = src.arrayOffset() + src.limit(); >>> 116: >> >> I see these

Re: RFR: 8261418: Reduce decoder creation overheads for sun.nio.cs.ext Charsets

2021-02-09 Thread Claes Redestad
On Tue, 9 Feb 2021 19:19:18 GMT, Naoto Sato wrote: >> This refactor some `sun.nio.cs.ext` charsets, such as ISO-2022-CN-GB, >> ISO-2022-CN-CNS, ISO-2022-KR and a few others to use static rather than >> per-instance auxiliary decoders. Doing so reduce overheads of calling >> `charset.newDecoder

Re: RFR: 8261418: Reduce decoder creation overheads for sun.nio.cs.ext Charsets [v2]

2021-02-09 Thread Claes Redestad
> This refactor some `sun.nio.cs.ext` charsets, such as ISO-2022-CN-GB, > ISO-2022-CN-CNS, ISO-2022-KR and a few others to use static rather than > per-instance auxiliary decoders. Doing so reduce overheads of calling > `charset.newDecoder()`. This reduce or eliminate regressions on `new > Stri

Re: RFR: 8261418: Reduce decoder creation overheads for sun.nio.cs.ext Charsets [v2]

2021-02-09 Thread Claes Redestad
On Tue, 9 Feb 2021 19:18:04 GMT, Naoto Sato wrote: >> Claes Redestad has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review fixes > > src/jdk.charsets/share/classes/sun/nio/cs/ext/ISO2022.java line 64: > >> 62: >> 63: protected

Re: RFR: 8261418: Reduce decoder creation overheads for sun.nio.cs.ext Charsets [v2]

2021-02-09 Thread Naoto Sato
On Tue, 9 Feb 2021 21:10:18 GMT, Claes Redestad wrote: >> src/jdk.charsets/share/classes/sun/nio/cs/ext/ISO2022.java line 64: >> >>> 62: >>> 63: protected final byte maximumDesignatorLength = 4; >>> 64: >> >> This implementation moved to KR concrete implementation class. IIUC, this is