RFR: 8259522: Apply java.io.Serial annotations in java.desktop

2021-01-11 Thread Sergey Bylokhov
Please review the application of @java.io.Serial annotation (JDK-8202385) to types in the desktop module to enable stricter compile-time checking of serialization-related declarations. This annotation can be applied to these methods in the module: private void writeObject(java.io.ObjectOutp

Re: RFR: 8257733: Move module-specific data from make to respective module [v4]

2021-01-11 Thread Magnus Ihse Bursie
On Mon, 4 Jan 2021 21:20:53 GMT, Phil Race wrote: >> Magnus Ihse Bursie has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains eight >> additional comm

RFR: 8259528: Broken Link for [java.text.Normalizer.Form]

2021-01-11 Thread Naoto Sato
Please review this simple doc fix. - Commit messages: - 8259528: Broken Link for [java.text.Normalizer.Form] Changes: https://git.openjdk.java.net/jdk/pull/2028/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2028&range=00 Issue: https://bugs.openjdk.java.net/browse/J

Re: RFR: 8259528: Broken Link for [java.text.Normalizer.Form]

2021-01-11 Thread Lance Andersen
On Mon, 11 Jan 2021 16:54:53 GMT, Naoto Sato wrote: > Please review this simple doc fix. Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2028

Re: RFR: 8259528: Broken Link for [java.text.Normalizer.Form]

2021-01-11 Thread Joe Wang
On Mon, 11 Jan 2021 16:54:53 GMT, Naoto Sato wrote: > Please review this simple doc fix. Oops, forgot to submit the review ;-) src/java.base/share/classes/java/text/Normalizer.java line 48: > 46: * The {@code normalize} method supports the standard normalization forms > 47: * described in >

Re: RFR: 8259528: Broken Link for [java.text.Normalizer.Form]

2021-01-11 Thread Iris Clark
On Mon, 11 Jan 2021 16:54:53 GMT, Naoto Sato wrote: > Please review this simple doc fix. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2028

Re: RFR: 8259528: Broken Link for [java.text.Normalizer.Form]

2021-01-11 Thread Naoto Sato
On Mon, 11 Jan 2021 17:35:58 GMT, Joe Wang wrote: >> Please review this simple doc fix. > > src/java.base/share/classes/java/text/Normalizer.java line 48: > >> 46: * The {@code normalize} method supports the standard normalization forms >> 47: * described in >> 48: * https://www.unicode.org/r

Re: RFR: 8259528: Broken Link for [java.text.Normalizer.Form]

2021-01-11 Thread Joe Wang
On Mon, 11 Jan 2021 16:54:53 GMT, Naoto Sato wrote: > Please review this simple doc fix. Marked as reviewed by joehw (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2028

Integrated: 8259528: Broken Link for [java.text.Normalizer.Form]

2021-01-11 Thread Naoto Sato
On Mon, 11 Jan 2021 16:54:53 GMT, Naoto Sato wrote: > Please review this simple doc fix. This pull request has now been integrated. Changeset: cd73939b Author:Naoto Sato URL: https://git.openjdk.java.net/jdk/commit/cd73939b Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod 8