I created a JIRA issue for this:
https://bugs.openjdk.java.net/browse/JDK-8253240
Naoto
On 9/16/20 2:11 AM, Pavel Rappo wrote:
On 15 Sep 2020, at 21:50, Rob Spoor wrote:
On 15/09/2020 22:02, Pavel Rappo wrote:
On 15 Sep 2020, at 20:50, Brian Burkhalter wrote:
On Sep 15, 2020, at 12:38
Hi,
Please review the fix to the issue wrt missing hashCode() javadoc, which was
recently discussed in core-libs ml.
-
Commit messages:
- 8253240: No javadoc for DecimalFormatSymbols.hashCode()
Changes: https://git.openjdk.java.net/jdk/pull/208/files
Webrev: https://webrevs.openj
On Wed, 16 Sep 2020 17:29:52 GMT, Naoto Sato wrote:
> Hi,
>
> Please review the fix to the issue wrt missing hashCode() javadoc, which was
> recently discussed in core-libs ml.
Changes requested by rriggs (Reviewer).
src/java.base/share/classes/java/text/DecimalFormatSymbols.java line 1153:
On Wed, 16 Sep 2020 17:29:52 GMT, Naoto Sato wrote:
> Hi,
>
> Please review the fix to the issue wrt missing hashCode() javadoc, which was
> recently discussed in core-libs ml.
Looks in line with the discussion on core-libs.
-
Marked as reviewed by lancea (Reviewer).
PR: https:/
> Hi,
>
> Please review the fix to the issue wrt missing hashCode() javadoc, which was
> recently discussed in core-libs ml.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Addressing Roger's comments.
-
Changes:
- all
On Wed, 16 Sep 2020 17:47:17 GMT, Roger Riggs wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressing Roger's comments.
>
> src/java.base/share/classes/java/text/DecimalFormatSymbols.java line 1153:
>
>> 1151:
On Wed, 16 Sep 2020 17:51:18 GMT, Lance Andersen wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressing Roger's comments.
>
> Looks in line with the discussion on core-libs.
Removing hashcode from the serialized
On Wed, 16 Sep 2020 19:53:26 GMT, Roger Riggs wrote:
>> Looks in line with the discussion on core-libs.
>
> Removing hashcode from the serialized form needs a CSR because it was
> non-transient in JDK 15.
> The intent is to not use the serialized value, so the readObject method
> should zero it
