Hi,
Please review this simple doc fix.
-
Commit messages:
- 8220483: Calendar.setTime(Date date) throws NPE with Date date = null
Changes: https://git.openjdk.java.net/jdk/pull/159/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=159&range=00
Issue: https://bugs.openj
On Mon, 14 Sep 2020 22:18:34 GMT, Naoto Sato wrote:
> Hi,
>
> Please review this simple doc fix.
Hi Naoto,
The change looks fine. I might have created a CSR just to track the doc change.
-
Marked as reviewed by lancea (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/159
On Mon, 14 Sep 2020 22:41:55 GMT, Lance Andersen wrote:
>> Hi,
>>
>> Please review this simple doc fix.
>
> Hi Naoto,
>
> The change looks fine. I might have created a CSR just to track the doc
> change.
The change looks fine. However, are other methods in the same situation, e.g.
void setT
On Mon, 14 Sep 2020 23:13:25 GMT, Naoto Sato wrote:
>> The change looks fine. However, are other methods in the same situation,
>> e.g. void setTimeZone(TimeZone value),
>> getInstance(Locale aLocale), etc.? Or, would it better to add a general
>> statement about passing in null values?
>
>
On Mon, 14 Sep 2020 22:52:50 GMT, Joe Wang wrote:
>> Hi Naoto,
>>
>> The change looks fine. I might have created a CSR just to track the doc
>> change.
>
> The change looks fine. However, are other methods in the same situation, e.g.
> void setTimeZone(TimeZone value),
> getInstance(Locale
On Mon, 14 Sep 2020 23:15:10 GMT, Naoto Sato wrote:
>> Thanks, Lance,
>>
>>> The change looks fine. I might have created a CSR just to track the doc
>>> change.
>>
>> Yes, and thanks for the CSR review too!
>
> Thanks, Joe.
>
>> The change looks fine. However, are other methods in the same si
On Mon, 14 Sep 2020 22:18:34 GMT, Naoto Sato wrote:
> Hi,
>
> Please review this simple doc fix.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/159
