Re: RFR: 8251499: no-placeholder compact number patterns throw IllegalArgumentException

2020-08-17 Thread naoto . sato
Hi Joe, It turned out that the previous fix did not address plural format cases. That means that just making the divisor negative to indicate non-placeholder cannot distinguish multiple plural cases with the same divisor. Instead, I created a list of placeholders (minimum digits) for each ind

Re: RFR: 8251499: no-placeholder compact number patterns throw IllegalArgumentException

2020-08-17 Thread Joe Wang
Hi Naoto, Looks good overall. One nit, blocks 1633-1639 and 1642-1649 may share a common private method with a parameter that takes either matchedPosIndex or matchedNegIndex, if you want. Best, Joe On 8/17/20 4:42 PM, naoto.s...@oracle.com wrote: Hi Joe, It turned out that the previous fix