RFR: 8251499: no-placeholder compact number patterns throw IllegalArgumentException

2020-08-14 Thread naoto . sato
Hello, Please review the fix for the following issue: https://bugs.openjdk.java.net/browse/JDK-8251499 The proposed changeset is located at: https://cr.openjdk.java.net/~naoto/8251499/webrev.00/ The current implementation of CompactNumberFormat assumes that there is always the number placeho

Re: RFR: 8251499: no-placeholder compact number patterns throw IllegalArgumentException

2020-08-14 Thread Joe Wang
Hi Naoto, Looks good to me. While a negative divisor representing no zeros is newly introduced, the "divisor > 0" checks seem to have always been beneficial.  I had to count the number of ""s in COMPACT_PATTERN13 :-) Have a great weekend! Joe On 8/14/2020 3:20 PM, naoto.s...@oracle.com wrot