Re: [14] RFR: 8222756: Plural support in CompactNumberFormat

2019-12-04 Thread Joe Wang
Hi Naoto, Looks good. I understand you'll update the webrev (with the added statement to readObject) once the CSR is approved. ResourceBundleGenerator.java might have been accidentally touched as there's no change there. I wonder if you need to guard the pluralRules input since you're buil

Re: Turkish Time Zone name string and translation

2019-12-04 Thread Yang, Letu
Hi Naoto, Can you review and approve the webrev? Thanks! https://cr.openjdk.java.net/~xliu/8234288/webrev.04/ Letu On 11/23/19, 6:09 PM, "naoto.s...@oracle.com" wrote: Looks good. Naoto On 11/22/19 9:55 PM, Yang, Letu wrote: > Hi Naoto, > > Added it in the

Re: Turkish Time Zone name string and translation

2019-12-04 Thread naoto . sato
Looks good, assuming the change between 03 and 04 is to fix "no new line..." Naoto On 12/4/19 11:38 AM, Yang, Letu wrote: Hi Naoto, Can you review and approve the webrev? Thanks! https://cr.openjdk.java.net/~xliu/8234288/webrev.04/ Letu On 11/23/19, 6:09 PM, "naoto.s...@oracle.com" wrote: