Re: [14] RFR 8212749: DecimalFormat.setGroupingSize(int) allows setting negative grouping size, 8231984: Clarify semantics of DecimalFormat.getGroupingSize(0)

2019-10-11 Thread Roger Riggs
Hi Naoto, The javadoc/spec comments look fine. Code comments at DecimalFormat:4035 give some latitute for the value to be out of range and since getGroupingSize returns the groupingSize byte it would be cleaner if the value was always in the valid range regardless of the isGroupingUsed boolean.

Re: [14] RFR 8212749: DecimalFormat.setGroupingSize(int) allows setting negative grouping size, 8231984: Clarify semantics of DecimalFormat.getGroupingSize(0)

2019-10-11 Thread naoto . sato
Thanks, Roger. Modified readObject() accordingly: https://cr.openjdk.java.net/~naoto/8212749.8231984/webrev.01/ Naoto On 10/11/19 10:41 AM, Roger Riggs wrote: Hi Naoto, The javadoc/spec comments look fine. Code comments at DecimalFormat:4035 give some latitute for the value to be out of rang