Re: [14] RFR: 8215181: Accounting currency format support

2019-08-07 Thread naoto . sato
Ping. Naoto On 7/31/19 5:57 PM, naoto.s...@oracle.com wrote: Hi, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8215181 The proposed changeset is located at: https://cr.openjdk.java.net/~naoto/8215181/webrev.00/ This is to enable "accounting" style c

Re: [14] RFR: 8215181: Accounting currency format support

2019-08-07 Thread Lance Andersen
Hi Naoto, I looked over the proposed changes and the bug. They seem reasonable to me. Best Lance > On Aug 7, 2019, at 4:12 PM, naoto.s...@oracle.com wrote: > > Ping. > > Naoto > > On 7/31/19 5:57 PM, naoto.s...@oracle.com wrote: >> Hi, >> Please review the fix to the following issue: >> https

Re: [14] RFR: 8215181: Accounting currency format support

2019-08-07 Thread Lance Andersen
Hi again Naoto, I meant to ask is there a CSR due to the change in the javadoc for NumberFormat? If not, there probably should > On Aug 7, 2019, at 4:17 PM, Lance Andersen wrote: > > Hi Naoto, > > I looked over the proposed changes and the bug. They seem reasonable to me. > > Best > Lance

Re: [14] RFR: 8215181: Accounting currency format support

2019-08-07 Thread naoto . sato
Thanks for the review, Lance. Yes, CSR is needed and it is already approved: https://bugs.openjdk.java.net/browse/JDK-8218770 Naoto On 8/7/19 1:20 PM, Lance Andersen wrote: Hi again Naoto, I meant to ask is there a CSR due to the change in the javadoc for NumberFormat?  If not, there probab

Re: [14] RFR: 8215181: Accounting currency format support

2019-08-07 Thread Lance Andersen
awesome, I must have missed it thinking it was a bug when I reviewed the bug itself (long day :-) ) …. > On Aug 7, 2019, at 4:24 PM, naoto.s...@oracle.com wrote: > > Thanks for the review, Lance. > > Yes, CSR is needed and it is already approved: > > https://bugs.openjdk.java.net/browse/JDK-82

Re: RFR: 8158880: test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale

2019-08-07 Thread Thejasvi Voniadka
Hi Naoto, Thank you for the review. This change has now been pushed. -Original Message- From: Naoto Sato Sent: Thursday, August 01, 2019 9:43 PM To: Thejasvi Voniadka ; i18n-dev@openjdk.java.net; core-libs-...@openjdk.java.net Subject: Re: RFR: 8158880: test/java/time/tck/java/time/f