Re: [12] RFR: 8216546: Support new Japanese era in java.lang.Character for Java SE 11

2019-01-31 Thread Chris Hegarty
Naoto, > On 31 Jan 2019, at 00:35, naoto.s...@oracle.com wrote: > > ... > > https://bugs.openjdk.java.net/browse/JDK-8217938 > http://cr.openjdk.java.net/~naoto/8216546/webrev.00/ This looks good. Just a few very minor comments. 1) To be consistent can you please include the addition of the

Re: [12] RFR: 8217892: Clarify the support for the new Japanese era in java.time.chrono.JapaneseEra

2019-01-31 Thread Chris Hegarty
Naoto, > On 31 Jan 2019, at 00:51, naoto.s...@oracle.com wrote: > > .. > https://bugs.openjdk.java.net/browse/JDK-8217939 > http://cr.openjdk.java.net/~naoto/8217892/webrev.00/ The changes look good. Reviewed. -Chris.

Re: [12] RFR: 8216546: Support new Japanese era in java.lang.Character for Java SE 11

2019-01-31 Thread Naoto Sato
Hi Chris, Thank you for the comments. I updated the CSR and the webrev: https://bugs.openjdk.java.net/browse/JDK-8217938 https://cr.openjdk.java.net/~naoto/8216546/webrev.01/ Naoto On 1/31/19 1:15 AM, Chris Hegarty wrote: Naoto, On 31 Jan 2019, at 00:35, naoto.s...@oracle.com wrote: ... h

Re: [12] RFR: 8216546: Support new Japanese era in java.lang.Character for Java SE 11

2019-01-31 Thread Chris Hegarty
> On 31 Jan 2019, at 17:07, Naoto Sato wrote: > > Hi Chris, > > Thank you for the comments. I updated the CSR and the webrev: > > https://bugs.openjdk.java.net/browse/JDK-8217938 > https://cr.openjdk.java.net/~naoto/8216546/webrev.01/ Thanks Naoto. Reviewed. -Chris