Re: [13] RFR 8215913: [Test_bug]java/util/Locale/LocaleProvidersRun.java failed on de_DE and ja_JP locale.

Hi Dora, Kindly update copyright years in both files and add bug id in LocaleProvidersRun.java. Other than that, it looks good to me. Thanks, Rachna On 1/4/19 7:58 AM, Dora Zhou wrote: Hello, Please help review the fix for the test bug java/util/Locale/LocaleProvidersRun.java failed on

Re: [12] RFR: 8215303: Allowing additional currency code points from later Unicode updates

Hi Naoto, Your fix looks good to me. Thanks, Rachna On 1/3/19 10:26 PM, Naoto Sato wrote: Hello, Please review the fix to the following issue (and its approved CSR): https://bugs.openjdk.java.net/browse/JDK-8215303 https://bugs.openjdk.java.net/browse/JDK-8215305 The proposed changeset is

Re: [12] RFR: 8215303: Allowing additional currency code points from later Unicode updates

Hi Naoto, just one nit, copyright year need to be updated in Character.java. Thanks, Rachna On 1/3/19 10:26 PM, Naoto Sato wrote: Hello, Please review the fix to the following issue (and its approved CSR): https://bugs.openjdk.java.net/browse/JDK-8215303 https://bugs.openjdk.java.net/brows

Re: [12] RFR: 8215303: Allowing additional currency code points from later Unicode updates

Changes looks fine to me. Regards, Nishit Jain On 03-01-2019 22:26, Naoto Sato wrote: Hello, Please review the fix to the following issue (and its approved CSR): https://bugs.openjdk.java.net/browse/JDK-8215303 https://bugs.openjdk.java.net/browse/JDK-8215305 The proposed changeset is located

Re: [12] RFR: 8215303: Allowing additional currency code points from later Unicode updates

On 1/3/19 10:26 PM, Naoto Sato wrote: > Hello, > > Please review the fix to the following issue (and its approved CSR): > > https://bugs.openjdk.java.net/browse/JDK-8215303 > https://bugs.openjdk.java.net/browse/JDK-8215305 > > The proposed changeset is located at: > > http://cr.openjdk.java

Re: [12] RFR: 8215303: Allowing additional currency code points from later Unicode updates

Hi Chris, Yes, it will affect the behavior of those methods. This has been discussed within the JLS folks, and their understanding was that the risk is minimal and OK to proceed. I was not involved in the discussion, but here are the reasons I can think of. - The Currency Symbols range is ve

Re: [12] RFR: 8215303: Allowing additional currency code points from later Unicode updates

Thanks Naoto. > On 4 Jan 2019, at 17:10, naoto.s...@oracle.com wrote: > > Hi Chris, > > Yes, it will affect the behavior of those methods. This has been discussed > within the JLS folks, and their understanding was that the risk is minimal > and OK to proceed. I was not involved in the discuss

Re: [12] RFR: 8215303: Allowing additional currency code points from later Unicode updates

Hi Rachna, Updated: http://cr.openjdk.java.net/~naoto/8215303/webrev.01/ Naoto On 1/4/19 2:24 AM, Rachna Goel wrote: Hi Naoto, just one nit, copyright year need to be updated in Character.java. Thanks, Rachna On 1/3/19 10:26 PM, Naoto Sato wrote: Hello, Please review the fix to the foll

Re: [12] RFR: 8215303: Allowing additional currency code points from later Unicode updates

Hi Chris, Yes. I just updated the CSR, adding the description in the compatibility risk: https://bugs.openjdk.java.net/browse/JDK-8215305 Naoto On 1/4/19 9:18 AM, Chris Hegarty wrote: Thanks Naoto. On 4 Jan 2019, at 17:10, naoto.s...@oracle.com wrote: Hi Chris, Yes, it will affect the b