Re: RFR: 8212676 AIX's CDE/MWM support

2018-12-04 Thread Ichiroh Takiguchi
Hello again. Could you give me review comment and/or suggestion ? Bug:https://bugs.openjdk.java.net/browse/JDK-8212676 Change: https://cr.openjdk.java.net/~itakiguchi/8212676/webrev.00/ Thanks, Ichiroh Takiguchi On 2018-11-26 21:27, Ichiroh Takiguchi wrote: Hello. Could you review the fi

Re: RFR: 8212676 AIX's CDE/MWM support

2018-12-04 Thread Phil Race
I haven't evaluated the merits of this proposal but this https://cr.openjdk.java.net/~itakiguchi/8212676/webrev.00/src/java.desktop/share/classes/sun/font/FontUtilities.java.udiff.html is not the right place to support a flag used in all these X11 files. And why is i18n-dev on the review ? I can'

[12] RFR: 8214770: java/time/test/java/time/format/TestNonIsoFormatter.java failed in non-english locales.

2018-12-04 Thread naoto . sato
Hello, Please review this simple fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8214770 The proposed fix is located at: http://cr.openjdk.java.net/~naoto/8214770/webrev.00/ It is simply specifying Locale.ROOT to expect the locale independent era names. Naoto

Re: [12] RFR: 8214770: java/time/test/java/time/format/TestNonIsoFormatter.java failed in non-english locales.

2018-12-04 Thread Lance Andersen
Looks OK Naoto > On Dec 4, 2018, at 1:52 PM, naoto.s...@oracle.com wrote: > > Hello, > > Please review this simple fix to the following issue: > > https://bugs.openjdk.java.net/browse/JDK-8214770 > > The proposed fix is located at: > > http://cr.openjdk.java.net/~naoto/8214770/webrev.00/ > >

Re: [12] RFR: 8214770: java/time/test/java/time/format/TestNonIsoFormatter.java failed in non-english locales.

2018-12-04 Thread Brian Burkhalter
+1 Brian > On Dec 4, 2018, at 10:59 AM, Lance Andersen wrote: > > Looks OK Naoto

Re: Fw: [PATCH] JDK-8213183: InputMethod cannot be used after its restarting

2018-12-04 Thread Toshio 5 Nakamura
Hello, Can anyone support this proposal? I appreciate any suggestion or comment. issue: https://bugs.openjdk.java.net/browse/JDK-8213183 webrev: http://cr.openjdk.java.net/~tnakamura/8213183/webrev.01/ Fix descriptions: - XSelectInput() in XMSelection.java may erase existing XRegisterIMInstant

[12]RFR 8213127: Refactor test/java/util/ResourceBundle/Control/MissingResourceCauseTest.sh to plain java tests

2018-12-04 Thread Dora Zhou
Hello, Please help review the fix for refactor test/java/util/ResourceBundle/Control/MissingResourceCauseTest.sh to plain java tests. Thank you. Bug: https://bugs.openjdk.java.net/browse/JDK-8213127 Webrev: http://cr.openjdk.java.net/~dzhou/8213127/webrev.02/ Regards, Dora