Re: RFR: JDK8U Backport of 8171049: Era.getDisplayName doesn't work with non-IsoChronology

2018-11-05 Thread naoto . sato
Looks good. Since you modified the test case, please add the copyright year 2018 in the test case before you push. Naoto On 11/4/18 10:26 PM, Deepak Kejriwal wrote: Hi all, Please review the fix for JDK8u Backport of https://bugs.openjdk.java.net/browse/JDK-8171049 Webrev: http://cr.op

Re: [12] RFR: 8213330: Fix legal headers in i18n tests

2018-11-05 Thread naoto . sato
Hi Lance, On 11/3/18 6:12 AM, Lance Andersen wrote: Hi Naoto Looks good over all. One question: * I noticed that some of the files had a copyright date and others did not.  For example: o test/jdk/sun/util/calendar/zi/tzdata/gmt  has a copyright o test/jdk/sun/util/calendar/