Hi Hamlin,
Just one nit, Please add bug id 8195478 to
sun/text/resources/LocaleDataTest.java.
Thanks,
Rachna
On 1/17/2018 1:37 PM, Hamlin Li wrote:
Would you please review the following patch?
bug: https://bugs.openjdk.java.net/browse/JDK-8195478
webrev as below
I have tested it locally
Looks good to me. As Rachna mentioned, please add @bug to
LocaleDataTest.java. No further review is needed.
Naoto
On 1/17/18 12:50 AM, Hamlin Li wrote:
Hi Rachna,
I'm not sure, but I think in this case (it's a test bug) @bug 8195478
should not be added.
Thank you
-Hamlin
On 17/01/2018 4
Hi Naoto,
I have pushed the code change to http://hg.openjdk.java.net/jdk/jdk10, I
think I need to push to 11 (http://hg.openjdk.java.net/jdk/jdk) too. Do
I need to send out for review again?
Thank you
-Hamlin
On 17/01/2018 9:06 PM, Naoto Sato wrote:
Looks good to me. As Rachna mentioned,
