Hi,
Please review the fix for JDK-8190278
Bug: https://bugs.openjdk.java.net/browse/JDK-8190278
Webrev: http://cr.openjdk.java.net/~nishjain/8190278/webrev.03/
Fix: Modified the code to check whether the object returned by
NumberFormat#getNumberInstance(Locale) is a DecimalFormat object, if no
Hi Peter,
Thanks for the tests. Looks good to me.
One nit: it should throw an Exception instead of AssertionError when the
test fails. No further review is needed.
> Can this go into JDK 10 ?
You can push it before the JDK 10 fork.
Naoto
On 12/9/17 2:33 PM, Peter Levart wrote:
Hi Naoto,
Looks good to me.
Naoto
On 12/11/17 1:04 AM, Nishit Jain wrote:
Hi,
Please review the fix for JDK-8190278
Bug: https://bugs.openjdk.java.net/browse/JDK-8190278
Webrev: http://cr.openjdk.java.net/~nishjain/8190278/webrev.03/
Fix: Modified the code to check whether the object returned by
Numb
Thanks Naoto, Alan, David and Venkat. The change is in.
Regards, Peter
Naoto Sato je 11. 12. 2017 ob 19:41 napisal:
Hi Peter,
Thanks for the tests. Looks good to me.
One nit: it should throw an Exception instead of AssertionError when
the test fails. No further review is needed.
> Can this