RFR: 8054214: JapaneseEra.getDisplayName doesn't return names if it's an additional era

2016-12-08 Thread Masayoshi Okutsu
Hi, Please review the fix for JDK-8054214. It was necessary to override Era::getDisplayName to get era names from the specified property. This one fixes getAbbreviation() as well. Issue: https://bugs.openjdk.java.net/browse/JDK-8054214 Webrev: http://cr.openjdk.java.net/~okutsu/9/8054214/web

Re: RFR: 8054214: JapaneseEra.getDisplayName doesn't return names if it's an additional era

2016-12-08 Thread Naoto Sato
Okutsu-san, In JapaneseEra::getDisplayName, Should there be Objects.requireNonNull() check for "style"? The current impl seems to return abbreviated era if null is passed as "style". Naoto On 12/8/16 12:55 AM, Masayoshi Okutsu wrote: Hi, Please review the fix for JDK-8054214. It was necess

RFR: 8039273: Font related files should not be modified in ${java.home}/lib

2016-12-08 Thread Phil Race
Bug: https://bugs.openjdk.java.net/browse/JDK-8039273 Webrev : http://cr.openjdk.java.net/~prr/8039273/ A CCC request and documentation are being prepared. -phil

Re: RFR: 8054214: JapaneseEra.getDisplayName doesn't return names if it's an additional era

2016-12-08 Thread Jonathan Bluett-Duncan
Hi Masayoshi, I'm not a reviewer, but there's something in JapaneseEra.java.cdiff.html which isn't terribly clear to me, so I wonder if you could clarify it for me. In