Re: RFR(xs): 8165936: Potential Heap buffer overflow when seaching timezone info files

2016-09-15 Thread Roger Riggs
Hi Thomas, It looks like NAME_MAX is not defined on Solaris and breaks the build on Solaris. [1] An alternative would be to conditionally use PATH_MAX. But I think it would be reasonable to just remove the use of NAME_MAX, since the following code increases the value to at least 1024, whic

RFR 9: 8166148 Fix for JDK-8165936 broke Solaris builds

2016-09-15 Thread Roger Riggs
Please review a fix for build breakage on Solaris. The NAME_MAX value does not seem to add much value in this case and is not defined on all supported platforms. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-max-8166148/ Issue: https://bugs.openjdk.java.net/browse/JDK-8166148 Thanks,

Re: RFR 9: 8166148 Fix for JDK-8165936 broke Solaris builds

2016-09-15 Thread Naoto Sato
+1 Naoto On 9/15/16 12:16 PM, Roger Riggs wrote: Please review a fix for build breakage on Solaris. The NAME_MAX value does not seem to add much value in this case and is not defined on all supported platforms. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-max-8166148/ Issue: https:/

Re: RFR 9: 8166148 Fix for JDK-8165936 broke Solaris builds

2016-09-15 Thread Thomas Stüfe
Hi Roger, Thank you for taking care of this! Fix looks fine. Kind Regards, Thomas On Thursday, 15 September 2016, Roger Riggs wrote: > Please review a fix for build breakage on Solaris. > The NAME_MAX value does not seem to add much value in this case and is not > defined on all supported plat