RFR: 8151431: DateFormatSymbols triggers this.clone() in the constructor

2016-04-06 Thread Masayoshi Okutsu
Hi all, Please review the fix for JDK-8151431. clone() is no longer called to create a cache entry. Issue: https://bugs.openjdk.java.net/browse/JDK-8151431 Webrev: http://cr.openjdk.java.net/~okutsu/9/8151431/webrev.00/ Thanks, Masayoshi

Re: RFR: 8151431: DateFormatSymbols triggers this.clone() in the constructor

2016-04-06 Thread Naoto Sato
Looks good overall. Here are my suggestions. - DateFormatSymbols.java: We could cache all candidate locales, e.g., if the requested locale is ja_JP_JP, and the bundle locale is ja, we could also put ja_JP bundle in the cache. - DateFormatSymbolsCloneTest.java: import sentence for the Locale c

Re: RFR: 8151431: DateFormatSymbols triggers this.clone() in the constructor

2016-04-06 Thread Masayoshi Okutsu
On 4/7/2016 2:44 AM, Naoto Sato wrote: Looks good overall. Here are my suggestions. Thank you for your quick review. - DateFormatSymbols.java: We could cache all candidate locales, e.g., if the requested locale is ja_JP_JP, and the bundle locale is ja, we could also put ja_JP bundle in the