[8u60] RFR: 7044727: (tz) TimeZone.getDefault() call returns incorrect value in Windows terminal session

2015-04-17 Thread Masayoshi Okutsu
Hello, Please review and approve the 8u version of the fix for JDK-7044727. This fix is different from the jdk9 one to be buildable and runnable on Windows XP. issue: https://bugs.openjdk.java.net/browse/JDK-7044727 8u webrev: http://cr.openjdk.java.net/~okutsu/8u/7044727/webrev.00/ jdk9 rev

Re: [8u60] RFR: 7044727: (tz) TimeZone.getDefault() call returns incorrect value in Windows terminal session

2015-04-17 Thread Naoto Sato
My only comment is that it could be confusing to use the same name "getDynamicTimeZoneInfo" for the function name and the proc address variable name (initially I thought if it were a recursive call). Otherwise it looks good to me. Also approving the backport to 8u. Naoto On 4/17/15 1:16 AM,

Re: [8u60] RFR: 7044727: (tz) TimeZone.getDefault() call returns incorrect value in Windows terminal session

2015-04-17 Thread Rob McKenna
Approved for push. -Rob On 18/04/15 00:05, Naoto Sato wrote: My only comment is that it could be confusing to use the same name "getDynamicTimeZoneInfo" for the function name and the proc address variable name (initially I thought if it were a recursive call). Otherwise it looks good to m