RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

2013-10-22 Thread Aleksej Efimov
Hi, Can I have a review for 8026772 [1] fix. The webrev link: [2] The timezone test is failed because of the changed TimeZone names introduced in 8025255 [3]. This timezone names were changed according to updated translation resource files introduced by 8025215 [4]. The fix changes the hard-co

[8] Request for review: 6607048: clear extra l10n resource files in demo

2013-10-22 Thread Michael Fang
Hello, Please help to review the changes for the following CR: https://bugs.openjdk.java.net/browse/JDK-6607048 The webrev is available here: http://cr.openjdk.java.net/~mfang/6607048/webrev.00/ Unit testing has been performed by yhuang. thanks

Re: [8] Request for review: 6607048: clear extra l10n resource files in demo

2013-10-22 Thread Naoto Sato
Looks good to me. Naoto On 10/22/13 10:40 AM, Michael Fang wrote: Hello, Please help to review the changes for the following CR: https://bugs.openjdk.java.net/browse/JDK-6607048 The webrev is available here: http://cr.openjdk.java.net/~mfang/

Re: [8] Request for review: 6607048: clear extra l10n resource files in demo

2013-10-22 Thread Michael Fang
Thanks Naoto for the review. -michael On 13年10月22日 11:21 上午, Naoto Sato wrote: Looks good to me. Naoto On 10/22/13 10:40 AM, Michael Fang wrote: Hello, Please help to review the changes for the following CR: https://bugs.openjdk.java.net/bro

[8] Request for review: 8026109: [ja] overtranslation of jarsigner in command line output

2013-10-22 Thread Michael Fang
Hello, Please help to review the changes (1 line fix) for the following CR: https://bugs.openjdk.java.net/browse/JDK-8026109 The webrev is available here: http://cr.openjdk.java.net/~mfang/8026109/ thanks! -michael

Re: [8] Request for review: 8026109: [ja] overtranslation of jarsigner in command line output

2013-10-22 Thread Naoto Sato
Looks good to me. Naoto On 10/22/13 11:33 AM, Michael Fang wrote: Hello, Please help to review the changes (1 line fix) for the following CR: https://bugs.openjdk.java.net/browse/JDK-8026109 The webrev is available here: http://cr.openjdk.java.net/~mfang/8026109/ thanks! -michael

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

2013-10-22 Thread Masayoshi Okutsu
Hi Michael, 27 *@summary Test case for tzdata2005m support for 9 locales What's the purpose of this test? Do we really need to keep this one? Thanks, Masayoshi On 10/22/2013 8:13 PM, Aleksej Efimov wrote: Hi, Can I have a review for 8026772 [1] fix. The webrev link: [2] The timezone test i