Re: RFR: JDK-8025712, , (props) Possible memory leak in java_props_md.c / ParseLocale

2013-10-10 Thread Chris Hegarty
Dan, Your changes look fine to me. While looking at this I notice that there is another potential leak. If the malloc for temp fails, then we need to free lc ( for MAC only ), right? -Chris. On 10/09/2013 07:51 PM, Dan Xu wrote: Hi All, This fix is to solve the memory leak issue in ParseLo

RFR: 8025255: (tz) Support tzdata2013g

2013-10-10 Thread Aleksej Efimov
Hi, Please, review the changes [1] needed to address the tz data update in JDK 8 from tzdata2013d to tzdata2013g. The brief list of changes: 1. tzdata2013g data was integrated to tzdb data files (make/sun/javazic/tzdata/* changes) and to sun/util/calendar test data files (test/sun/util/calen

Re: RFR: JDK-8025712, , (props) Possible memory leak in java_props_md.c / ParseLocale

2013-10-10 Thread Naoto Sato
You could, but that part only relates to the @euro locales handling, which is at this moment almost obsolete, let alone for MacOSX platform. So the current code should work fine. Naoto On 10/10/13 1:23 PM, Dan Xu wrote: Good catch, Chris. Btw, according to the description, it seems the block

Re: RFR: 8025255: (tz) Support tzdata2013g

2013-10-10 Thread Masayoshi Okutsu
Hi Aleksej, Here are my review comments. - The copyright header of the data files shouldn't be removed. - TimeZoneNames.java: - "Middle Europe Time", "MET"}}, + "MET", "MET"}}, I don't think the long name should be changed. I