Re: Review Request for 8074431: Remove native2ascii tool

2015-05-20 Thread Jonathan Gibbons
On 05/18/2015 03:45 PM, Mandy Chung wrote: This patch removes native2ascii command-line tool from JDK 9 as proposed in March [1]. Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8074431/webrev.00/ Jon - A langtools test is updated to use a new Native2Ascii.java helper class instea

Re: Review Request for 8074431: Remove native2ascii tool

2015-05-19 Thread Erik Joelsson
Looks good to me. /Erik On 2015-05-19 00:45, Mandy Chung wrote: This patch removes native2ascii command-line tool from JDK 9 as proposed in March [1]. Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8074431/webrev.00/ Jon - A langtools test is updated to use a new Native2Ascii.jav

Re: Review Request for 8074431: Remove native2ascii tool

2015-05-19 Thread Alan Bateman
On 18/05/2015 23:45, Mandy Chung wrote: This patch removes native2ascii command-line tool from JDK 9 as proposed in March [1]. Looks good. -Alan

Review Request for 8074431: Remove native2ascii tool

2015-05-18 Thread Mandy Chung
This patch removes native2ascii command-line tool from JDK 9 as proposed in March [1]. Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8074431/webrev.00/ Jon - A langtools test is updated to use a new Native2Ascii.java helper class instead. Existing code that calls sun.tools.nativ