Thanks Naoto, Alan, David and Venkat. The change is in.
Regards, Peter
Naoto Sato je 11. 12. 2017 ob 19:41 napisal:
Hi Peter,
Thanks for the tests. Looks good to me.
One nit: it should throw an Exception instead of AssertionError when
the test fails. No further review is needed.
> Can this
Hi Peter,
Thanks for the tests. Looks good to me.
One nit: it should throw an Exception instead of AssertionError when the
test fails. No further review is needed.
> Can this go into JDK 10 ?
You can push it before the JDK 10 fork.
Naoto
On 12/9/17 2:33 PM, Peter Levart wrote:
Hi Naoto,
Hi Naoto,
Thank you for reviewing.
Naoto Sato je 06. 12. 2017 ob 20:41 napisal:
Hi Peter, Venkat,
Thank you for the fix. It looks good to me. Improved performance is a
nice bonus! Would you be able to provide with a regression test?
Sure, here it is:
http://cr.openjdk.java.net/~plevart/jdk
Hi Peter, Venkat,
Thank you for the fix. It looks good to me. Improved performance is a
nice bonus! Would you be able to provide with a regression test?
Naoto
On 12/6/17 6:10 AM, Peter Levart wrote:
Hi,
On 12/06/2017 02:30 PM, Alan Bateman wrote:
I think this class is normally maintained on
Hi,
On 12/06/2017 02:30 PM, Alan Bateman wrote:
I think this class is normally maintained on i18n-dev but I think
introducing the Cache object looks good and making this much easier to
understand.
-Alan
Thanks Alan, I'm forwarding to i18n-dev to see if maintainers of that
part of JDK have
